Comments (7)
Thank you @brandly
from lax.
Yep, I see this as well. I don't mind the behavior, as long as there's a back button.
But I guess the expected behavior is to open in default browser.
from lax.
But I guess the expected behavior is to open in default browser.
Yes! I swear it used to behave like this. I don’t think I’ve touched anything over there in a while, so maybe updating Electron itself broke it. It’s probably not a difficult fix.
from lax.
I see you're using shell.openExternal
which seems correct. Perhaps the event is bubbling up to react-linkify
nevertheless.
from lax.
Curious if we need handleLink()
at all. Does does passing target: '_blank'
not behave within the Electron shell?
from lax.
@srirangan thanks for chiming in, helped motivate me to actually do something lol
the latest version of react-linkfy
doesn't seem to take a properties
prop at all. instead of figuring out if there's a new approach, i just rolled back.
after rolling back, i tried the target: '_blank'
approach, since i thought that'd be nice. however, that opened a second electron window with the site in it. with openExternal
, it takes you to your real browser.
from lax.
Lax v0.6.5
should be out soon. try it out and lmk if it works well for you. thanks again!
from lax.
Related Issues (20)
- add to list of electron apps HOT 1
- build system HOT 1
- follow up with hegel HOT 1
- [Question] HOT 1
- cache dependencies in CI
- fully support Windows HOT 12
- electron 7 is out
- Automatically switch to dark mode using Ambient Light Sensor API HOT 1
- dark mode people list input is white-on-white
- select font in settings
- click name to /msg them HOT 1
- add "leave channel" button to dropdown menu
- electron 8
- github actions creating release when it shouldn't
- update electron
- Nickname change not reflected in UI HOT 1
- Able to highlight UI elements HOT 2
- Channel joins with 0 members when not allowed to join HOT 2
- Server icon/label customization HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lax.