Bug: Private Message are sent to me about lax

[brandly]

i don't know anything about ZNC, but here's what i found.

here's where we receive a message and dispatch it as a RECEIVE_DIRECT_MESSAGE:

https://github.com/brandly/irc/blob/5094c3d74578ca01dde37108f6cbde43cd519db6/src/js/actions/connections.js#L168-L174

IRC names are case-insensitive, but it's checking if (e.to === nickname). there are a couple places names get compared in this reducer as well.

i think we should define a case-insensitive name equality function via localCompare and use it wherever we compare names

you think that'd fix it?

[brandly]

this section of the spec is interesting: https://tools.ietf.org/html/rfc2812#section-2.2

Because of IRC's Scandinavian origin, the characters {}|^ are
considered to be the lower case equivalents of the characters []~,
respectively. This is a critical issue when determining the
equivalence of two nicknames or channel names.

i don't fully understand, but there's a discussion here.

so it looks like there are some edge cases, but this would work most of the time and would definitely be better than our current === comparison:

function equalNames(a, b) {
  return a.toUpperCase() === b.toUpperCase()
}