Coder Social home page Coder Social logo

Comments (5)

grmmph avatar grmmph commented on June 2, 2024

Ok, seems like the main issue caused because of confusion with the branch api live and test keys.

But still it could be improved:

  • unifying links
  • type: 2 doesn't add links to marketing table

from branch-deep-linking-public-api.

aaustin avatar aaustin commented on June 2, 2024

Hey @grmmph - I'm super sorry that you went through this torture. Key mixups are unfortunately all too common. We added that system to help companies better segment their test data from live data, but it seems like it sometimes adds more pain than benefit.

On your suggestions, we worry about unifying links between the two accounts, because it allows potentially bad behavior where people launch with the incorrect keys and can use them interchangeably. It's one of the reasons that we now create all links with test-app.link on the test account, to help prevent this confusion.

On type:2 not creating a marketing link, I just checked that this should still be working. Can you make sure you're passing it as an integer and not a string? I thought we handle both but it's possible that's not the case.

from branch-deep-linking-public-api.

grmmph avatar grmmph commented on June 2, 2024

Thanks for quick reply @aaustin!

Indeed using the test key was a stupidity on my side. But Actually, I didn't get xxx.test-app.link as you suggested, but the xxx.app.link - maybe if I would have get the test-app response I would realize much faster I'm using a wrong key. Maybe something to improve on your side?

Yes, type: 2 was passed as integer at the root of the params object (not an attribute of data)

from branch-deep-linking-public-api.

aaustin avatar aaustin commented on June 2, 2024

Hey @grmmph - I just tried this curl for a test app I have:
curl -X POST -H "Content-Type: application/json" -d '{"channel":"test","campaign":"test123","type":2,"data":"{\"$always_deeplink\":false}","branch_key":"key_live_gpk6Xg4wInPq1IYbxwG4akjhqDc7bplS"}' https://api.branch.io/v1/url

Upon reloading the marketing page, the link appeared. Can you send over an example request you make where this doesn't happen? I can help dig in there.

from branch-deep-linking-public-api.

aaustin avatar aaustin commented on June 2, 2024

Going to close the issue for now.

from branch-deep-linking-public-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.