Broken export in 1.6.1 about fontfaceobserver

[bramstein]

Just so I understand the issue: you were using FontFaceObserver as a module and relied on its constructor being in the global window? Your suggestions is to, in addition to the module export, assign the constructor to the global window?

[tvararu]

Yes. That would not break backwards compatibility.

Here is a diff of the commit that fixed our application, which was breaking earlier with v1.6.1:

-    require('fontfaceobserver') // global
+    var FontFaceObserver = require('fontfaceobserver')

[bramstein]

I think that's a good point, I'll fix it. I just realised the commonjs package doesn't include the Promise polyfill by default either (I assumed most people would want to include that separately --- or use a different library).

[mathisonian]

👍 for this. I ran into the same problem with the minor version upgrade breaking a build. @tvararu's suggestions make sense to me

[bramstein]

Thanks, it's in v1.6.2 now. Let me know if you run into any problems.

[tvararu]

Thanks a lot! 🙌