FFmpegBuilder API is not intuitive about ffmpeg-cli-wrapper

[bramp]

Thanks for your feedback. I debated a few different implementations of supporting the OutputBuilder. However, I think you missed the done() method to go back to the original builder, for example:

List<String> args = new FFmpegBuilder()
  .setInput("input.mp4")     // Filename, or a FFmpegProbeResult

  .addOutput("output.mp4")   // Filename for the destination
    .setFormat("mp4")        // Format is inferred from filename, or can be set
    .setVideoCodec("libx264")     // Video using x264
    .done()

  .addOutput("output.flv")   // Filename for the destination
    .setFormat("flv")        // Format is inferred from filename, or can be set
    .done()

  .build();

If I understand your proposal you would prefer something like:

List<String> args = new FFmpegBuilder()
  .setInput("input.mp4")     // Filename, or a FFmpegProbeResult

  .addOutput(new FFmpegOutputBuilder()
    .setName("output.mp4") // Filename for the destination
    .setFormat("mp4")        // Format is inferred from filename, or can be set
    .setVideoCodec("libx264")     // Video using x264
  )   

  .addOutput(new FFmpegOutputBuilder()
    .setName("output.flv")   // Filename for the destination
    .setFormat("flv")        // Format is inferred from filename, or can be set
  )

  .build();

[genrym]

Sorry, yes, I missed the done functionality. If this exists, my proposal lowers in priority.

Your elaboration of my proposal is correct.
This can simplify your example to the following:

List<String> args = new FFmpegBuilder()
   .setInput("input.mp4")     // Filename, or a FFmpegProbeResult

  .addOutput(createMP4Builder(15))    // with 15 FPS 
  .addOutput(createMP4Builder(30)     // with diff FPS
  .addOutput(createFLVBuilder())      // diff format 
  .build();

[bramp]

So it turns out with very minimal changes, and without breaking the API, I was able to make this work. To avoid confusion, this won't be the main way used in the examples, but it will be documented, and tested.

[genrym]

Wow, thanks for the enhancement, looks great :)