Comments (6)
cupaloy.New(cupaloy.UseStringerMethods(false)).SnapshotT(t, hours)
from cupaloy.
Ah awesome there already is an option for disabling String()
methods!
from cupaloy.
Hey @mattharrigan do you have an example of a test where you're seeing this inconsistency?
By double spaces are you meaning between the snapshots of variables or actually within the snapshot of a single variable?
Sorry for not replying sooner, the GitHub notification for this is showing as 6 hours ago 🤔
from cupaloy.
Hey @bradleyjkemp, I'm getting the same issue. The snapshot output for all tests seem to change from single / double spaces at random.
--- FAIL: Test_Repository/get_opening_hours (0.00s)
client_test.go:223: snapshot not equal:
--- Previous
+++ Current
@@ -1,2 +1,2 @@
-(*api.GetOpeningHoursSpecificationResponse)(specification:{dayOfWeek:2 opens:"11:00" closes:"22:00" validFrom:"3000-11-01T00:00:00Z" validThrough:"3000-12-01T00:00:00Z"})
+(*api.GetOpeningHoursSpecificationResponse)(specification:{dayOfWeek:2 opens:"11:00" closes:"22:00" validFrom:"3000-11-01T00:00:00Z" validThrough:"3000-12-01T00:00:00Z"})
{
name: "get opening hours",
test: func(t *testing.T) {
ctx := context.Background()
hours, err := repository.GetOpeningHoursSpecification(ctx, &api.GetOpeningHoursSpecificationRequest{
VenueId: UUID,
Date: "3000-11-11T00:00:00Z",
})
require.NoError(t, err)
cupaloy.SnapshotT(t, hours)
},
},
from cupaloy.
Ah are you using protobuf by any chance?
The default protobuf String()
method intentionally introduces randomness: golang/protobuf#1269
Cupaloy shouldn't really be using the String() method by default but it'd be a breaking change to disable the behaviour. Cupaloy should probably have an option to disable this though.
An alternative is to marshal your protobuf message yourself before passing it to Cupaloy
from cupaloy.
thanks @bradleyjkemp 👍 , didn't know about that protobuf behaviour
from cupaloy.
Related Issues (20)
- Control whether snapshot mismatches are t.Errors or t.Fatals
- Fix Sourcegraph badge HOT 2
- Explain cupaloy better in README
- Be able to identify and clean up unused snapshots HOT 1
- Clarify WithOptions semantics
- Include snapshot diff in log/error when snapshots are updated/created
- Do not spew results using Stringer methods? HOT 1
- Automate adding .gitattributes tagging snapshots as generated files
- Make Cupaloy into a Go module HOT 1
- Add SnapshotMultiT function HOT 5
- Fix broken Sourcegraph badge HOT 1
- Sort map keys when spewing HOT 4
- Use of internal package not allowed HOT 2
- Dependabot can't resolve your Go dependency files
- Add an option to write failed/changed snapshots to disk
- can't install HOT 2
- Feature request: support Property Matchers like Jest HOT 1
- Support for JSON Snapshots HOT 1
- Snapshot filename special character scrub needed - semicolon
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cupaloy.