Coder Social home page Coder Social logo

Comments (5)

bradgarropy avatar bradgarropy commented on May 30, 2024 1

Jut saw your last comment! Right, the Time type expects both minutes and seconds. I should totally make that compatible with what's passed into the hook at the beginning.

Could you open an issue to start with? And if you want to submit the pull request that would be 💯

from use-countdown.

ndimatteo avatar ndimatteo commented on May 30, 2024

Spoke too soon! Looks like if you omit the minutes property during a reset that causes it.

I think this should probably be allowed, considering it works during the initial hook render, happy to take a stab at a PR for that when I have the time

from use-countdown.

bradgarropy avatar bradgarropy commented on May 30, 2024

Thanks for filing an issue @ndimatteo!

I think you're seeing an error because of the value you are passing to reset. Reset accepts a Time input that looks like this:

type Time = {
    minutes: number
    seconds: number
}

So in your case you should not pass in the format property. It would look something like this:

resendCodeCountdown.reset({ seconds: 30 })

from use-countdown.

bradgarropy avatar bradgarropy commented on May 30, 2024

@all-contributors please add @ndimatteo for bug

from use-countdown.

allcontributors avatar allcontributors commented on May 30, 2024

@bradgarropy

I've put up a pull request to add @ndimatteo! 🎉

from use-countdown.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.