Coder Social home page Coder Social logo

Comments (7)

drewhamlett avatar drewhamlett commented on May 29, 2024

Hey @FezVrasta, we can definitely take a look at it, but I think you maybe getting hung up on too many edge cases. I've been using jsbeautify for years and it's been really good. It follows JSlint styling very well. They've always seem to put in the requests I submit.

I feel like your pain maybe with the css formatting anyway(as is mine) and I've already been looking around for other css formatters. I don't mind replacing the CSS and HTML formatter at any time. I'm all for that. I'm not for replacing the javascript formatter so swiftly though.

Jsbeautify has 5 years of tackling the edge cases where Pretty-Diff doesn't have that yet. That's 90% of the problems making a formatter.

I don't mind bringing in Pretty-Diff anyway because I've been trying to get basic php formatting support in. It looks pretty good. We could just bring it in, and maybe even have a formatting library selection. Or it could make sense as a separate extension. Not sure.

For JSbeautify, you may want to try to submit your request not as a pull request but a just as a feature request.

Let me know what you think. Thanks!

from brackets-beautify.

FezVrasta avatar FezVrasta commented on May 29, 2024

Thanks,

yes I've huge problems with the CSS formatting using beautify-js, I definetely can not use it on my CSS and LESS files because it breaks too many things.

I can't neither try to beautify PHP templates because beautify-js doesn't support PHP, even if is just for some little variable inside the code.

I thought that use Pretty-Diff to beautify every kind of language could be easier than just use it for PHP and use the bugged beautify-js for the rest.

I'd like to develop a separated extension if you don't liekt o replace beautify-js. But I've not time and probably I'm not enough skilled to write this extension.

from brackets-beautify.

ffrappo avatar ffrappo commented on May 29, 2024

I'd like to back FezVrasta request, at least for CSS. Currently it's totally breaking all CSS pseudo selectors. Things will actually fail in the browser if the user doesn't notice and revert the "beautification".

from brackets-beautify.

drewhamlett avatar drewhamlett commented on May 29, 2024

Ok guys, so I played around with the PrettyDIFF css formatter. While we may think that cssbeautify has a few issues, it doesn't have near the problems PrettyDIFF does. After testing it for a while it breaks on some basic things.

@FezVrasta JSbeautify did close your issue, beautify-web/js-beautify#363, and it seems to be great.

I pulled that in. You should download the github repo and test it out. I'm closing this for now, because it fixes the issue a bunch of people were having. We'll reopen this if there are more issues.

from brackets-beautify.

ffrappo avatar ffrappo commented on May 29, 2024

Awesome! Works like a charme now. Thanks guys.

from brackets-beautify.

FezVrasta avatar FezVrasta commented on May 29, 2024

if the problem was just that one... it has lot of problems with LESS. With pretty Diff I can't really find any problem instead.

from brackets-beautify.

bitwiseman avatar bitwiseman commented on May 29, 2024

@FezVrasta - please flie the issue you find. That's the only way the project will improve.

from brackets-beautify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.