Coder Social home page Coder Social logo

Comments (2)

bpuig avatar bpuig commented on June 27, 2024 1

We have to always think that there is user side, but also there can be admin side to the app, so I need to be careful of not closing and restricting too much the package.

So one can do because knows plan 2 exists and is active:

$plan = Plan::find(2);
$user->newSubscription('main', $plan);

But also manage the same endpoint for both admin and user perspective, so Super Admin can assign plan to users but users only to themselves.

$isSuperAdmin = auth()->user()->hasRole('Super Admin');

$user = ($isSuperAdmin) ? User::findOrFail($request->user_id) : auth()->user();

$plan = ($isSuperAdmin) ? Plan::findOrFail($request->plan_id) : Plan::where('id', $request->plan_id)->where('is_active', true)->firstOrFail();

$user->newSubscription('main', $plan);

If an error is thrown when calling newSubscription because plan is not active it can be a pain to create the subscription from an admin perspective, because maybe there are "secret plans" that you do not want to be active to the public but able to the admin to attach a subscription.

from laravel-subby.

boryn avatar boryn commented on June 27, 2024

Totally understood, the library should not limit subscribing to not active plans.

from laravel-subby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.