Coder Social home page Coder Social logo

Comments (3)

bpuig avatar bpuig commented on August 22, 2024 1

Solved in e3d2f33

from laravel-subby.

bpuig avatar bpuig commented on August 22, 2024

Would not be better to just throw an exception "subscription does not exist" or similar?
Because returning null might get you thinking subscription exists and starting one of that circles where you do not know what is not working and end up finding you were pointing the wrong subscription all the time and end up like: 🤦‍♂️

Also I'm writing this without looking at the code. Let me see it today and fix one way or another before release.

from laravel-subby.

boryn avatar boryn commented on August 22, 2024

Yes, I was thinking about the exception as well. If properly used by a developer, would be a better solution :) And it would be on the part of developer to handle it properly.

It would be worth mentioning in the docs that it's recommendable to wrap $user->subscription('primary')->getFeatureUsage('social_profiles'); in the try/catch block.

from laravel-subby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.