Coder Social home page Coder Social logo

Comments (4)

trianity avatar trianity commented on July 2, 2024

Please review all the suggested changes in the fork at https://github.com/AkkuFresh/laravel-admin-starter

from laravel-admin-starter.

bpocallaghan avatar bpocallaghan commented on July 2, 2024

Hi @AkkuFresh
Thanks for the great feedback.
Yeah, the 'General' was really just a temporary storage until I move all of them into their proper namespace (\Banners, \Misc or whatever) - was still undecided. But I do admit, this is a bit nicer to already give them their namespace.

I also like that you moved User to the Models, I was also undecided about that one (due to the default location of laravel saving it there)

But very well done on the updates, always nice to do some refactor/cleanup :)
Thanks a lot.
Do you want to push them into the main branch or ?

from laravel-admin-starter.

bpocallaghan avatar bpocallaghan commented on July 2, 2024

merged the changes.
Thanks again - please feel free to keep contributing :)

from laravel-admin-starter.

trianity avatar trianity commented on July 2, 2024

Your welcome!

from laravel-admin-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.