Coder Social home page Coder Social logo

Comments (5)

hugoetchegoyen avatar hugoetchegoyen commented on July 30, 2024

Bowen, now that expr() has been removed, test/optexpr.cpp is meaningless and should be removed too.
Best regfards,
Hugo

from matchit.cpp.

BowenFu avatar BowenFu commented on July 30, 2024

Hi @hugoetchegoyen, "expr()" will be kept at least until next major release. So it is better to keep the tests.

Since documentation has been updated in #98, I'm going to close this issue.

from matchit.cpp.

hugoetchegoyen avatar hugoetchegoyen commented on July 30, 2024

Ok, but in that case I guess optexpr.cpp should not be cleaned up of unnecessary expr()s. As it is now, both test cases (no_expr and unnecessary_expr) are identical and expr() is not used at all.

from matchit.cpp.

BowenFu avatar BowenFu commented on July 30, 2024

Ok, but in that case I guess optexpr.cpp should not be cleaned up of unnecessary expr()s. As it is now, both test cases (no_expr and unnecessary_expr) are identical and expr() is not used at all.

That should be a mistake. Will recover that file.

from matchit.cpp.

BowenFu avatar BowenFu commented on July 30, 2024

Will be fixed by #99

from matchit.cpp.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.