Coder Social home page Coder Social logo

Comments (23)

Bouni avatar Bouni commented on June 15, 2024 6

πŸ₯³

This not yet fully automated but it works for now!

image

Add my addon repo and you can install the plugin via the Plugin Manager 😁

Edit:

The URL is https://raw.githubusercontent.com/Bouni/bouni-kicad-repository/main/repository.json

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024 5

I thought exactly that after reading @arturo182 's tweet yesterday πŸ˜„
I'll defenitely do that, but that will take a little more time in order to get things to comply with their rules.

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024 3

I currently work on a GitHub action that generates the needed files for submission to the PCM repo every time I create a release.
Once that works I'll submit to PCM πŸ€“

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024 2

πŸ₯³

When ever I create a new release, a ZIP file is generated using GitHub actions and uploaded as a release asset.
Then the regeneration, also a GitHub action of the custom addon repo is trigged via a workflow_dispatch.
That keeps the repo up-to-date automatically! The only downside is the 5 minute cache timeout on those files.
If you try to load the addon in this period you'll most likely get an error that the sha256 sums are not correct.

All in all I can live with this solution 😁

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024 2

I've finally got an email from JLCPCB but they did not say anything about the PCM issue.
I answered with another request to send that email to the KiCAD addon team.

We'll see if the do it or not (or let us wait another 3 months ... 😏 )

from kicad-jlcpcb-tools.

OmegaRogue avatar OmegaRogue commented on June 15, 2024 1

I think some sort of unofficial or community PCM repo would be useful for this sort of thing

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024 1

I'll close this as JLCPCB is not willing to support my efforts 😞

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

Lets see if this succeeds: https://gitlab.com/kicad/addons/metadata/-/merge_requests/22

At the moment when I create a new release the files are generated automatically and added as release assets but I still have to manually create a Merge Request over at GitLab. Maybe I can automate that as well in the future ....

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

😒
I tottaly overlooked this section of the dev docs on PCM addons:

Commercial Services

Packages that link to or provide commercial services, including but not limited to PCB fabrication, component lookup and order management, must first contact the KiCad team at [email protected] to discuss commercial plugin options.

So this plugin will never be in the official PCM list (I doubt JLC will do anything to convince KiCAD to do that), but I'm going to create a custom repo that can be added to the PCM list of repos which will make the plugin installabel from there.

from kicad-jlcpcb-tools.

AiGreek avatar AiGreek commented on June 15, 2024

So this plugin will never be in the official PCM list (I doubt JLC will do anything to convince KiCAD to do that), but I'm going to create a custom repo that can be added to the PCM list of repos which will make the plugin installabel from there.

Are they **** serious ?? Just because it's for JLCPCB you can't publish it ? sigh

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

That's how it is 🀷

Anyway, I think my custom repo is a good alternative.

from kicad-jlcpcb-tools.

mikwielgus avatar mikwielgus commented on June 15, 2024

@Bouni Are you confident that JLCPCB is not going to contact the KiCad team to approve your plugin if asked?

As far as I know, the plugin doesn't have to originate from the commercial entity it interacts with (i.e. it can be third party), but we just need to obtain an explicit approval from that entity. I've asked Seth to clarify what he wrote in your merge request.

The wording in the developer docs should be clarified, as it clearly has caused some confusion. And I definitely want your plugin to be available in the official repository.

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

@mikwielgus I don't know but so far JLC never answerd a single of my e-mails with inquiries (see #55 ).
They promised in the live chat to reach out to me but nothing happened so far.

But if you guys clearify if a simple "go for it" form the comercial entity is enough, I'll try to get JLC to send that e-mail πŸ˜„

And I definitely want your plugin to be available in the official repository.

Thanks for your support ☺️

from kicad-jlcpcb-tools.

mikwielgus avatar mikwielgus commented on June 15, 2024

Just to be clear, it's more than just a simple "go for it" -- apparently a contract is necessary as it stands currently (I don't yet know exactly why) -- but this obviously also can be done. It's well within JLCPCB's interest to get your plugin in the official repository.

Please keep me updated with your progress if you intend to go with this. I'll try to help if there are some obstacles.

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

Ok, thats about what I expected.
Is "apparently a contract is necessary as it stands currently (I don't yet know exactly why)" the answer you've got from Seth?

I'll see if JLCPCB is willing to do whats neccessary but before I ask them it would be nice to have a clear statement what exactly is needed in order to get permission.

from kicad-jlcpcb-tools.

yaqwsx avatar yaqwsx commented on June 15, 2024

@Bouni: See the discussion on the KiCAD's Discord server in the channel scripting (about two days ago). I was discussing it with Seth and Jon - there is a useful insight and explanation.

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

You guys are just awesome! Thanks for all your efforts getting this into the offical PCM repo πŸ˜„

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

Just for documentation purposes, @yaqwsx asked @JLCPCB on Twitter for help with this issue and they said the woul reach out to me later (Whenever "later" might be 😏 ) https://twitter.com/JLCPCB/status/1470305011846762496

from kicad-jlcpcb-tools.

OmegaRogue avatar OmegaRogue commented on June 15, 2024

I think some sort of unofficial or community PCM repo would be useful for this sort of thing

https://github.com/OmegaRogue/Unofficial-KiCad-Plugins I'm setting one up, the github actions workflow isn't working yet, but it's essentially just one script that gets executed

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

I was in touch with JLCPCB via Twitter private messages after I've posted this. After Christmas I should get a reply on this topic πŸ₯³

from kicad-jlcpcb-tools.

OmegaRogue avatar OmegaRogue commented on June 15, 2024

Any update on this?

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 15, 2024

Nope, a lot of promises from JLC but nothing else so far ...

from kicad-jlcpcb-tools.

OmegaRogue avatar OmegaRogue commented on June 15, 2024

in the meantime, feel free to submit it to my unofficial repo

from kicad-jlcpcb-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.