Comments (4)
@lcreid Any more concrete example for this?
from bootstrap_form.
If I search for join
in the code excluding test/
, and eliminating the instances that are joining file paths, I find these:
lib/bootstrap_form/form_builder.rb:
69 ([*options[:html][:class]&.split(/\s+/)] + %w[row row-cols-auto g-3 align-items-center])
70: .compact.uniq.join(" ")
71 end
lib/bootstrap_form/form_group_builder.rb:
93 control_classes = css_options.delete(:control_class) { control_class }
94: css_options[:class] = [control_classes, css_options[:class]].compact.join(" ")
95 css_options[:class] << " is-invalid" if error?(method)
lib/bootstrap_form/components/validation.rb:
83
84: object.errors[name].join(", ")
85 end
lib/bootstrap_form/helpers/bootstrap.rb:
34 if hide_attribute_name
35: object.errors[name].join(", ")
36 else
37: object.errors.full_messages_for(name).join(", ")
38 end
95 end
96: ActiveSupport::SafeBuffer.new(tags.join)
97 end
lib/bootstrap_form/inputs/rich_text_area.rb:
12 prepend_and_append_input(name, options) do
13: options[:class] = ["trix-content", options[:class]].compact.join(" ")
14 rich_text_area_without_bootstrap(name, options)
The code has been like this for a long time and we have no complaints. And if it's "broken", I think it's broken in the safe direction, meaning it will err on the side of escaping HTML. It's just something that I've always wanted to look at. Maybe when I retire, if I can ever afford to. Ha ha.
from bootstrap_form.
I propose we either define what needs to change or close this issue and #653 .
from bootstrap_form.
I took a run at this last week when my COVID wasn't so bad and ran into one case where the right solution isn't obvious. Still working on it.
from bootstrap_form.
Related Issues (20)
- Option to provide `is-invalid` class to labels along with fields HOT 1
- Range control has wrong class HOT 5
- Release version 5.2.0 HOT 8
- Need to include ActiveRecord::Reflection for custom form class with 5.2.0 HOT 1
- Rename the default layout to "vertical" ? HOT 2
- Can't disable number_field HOT 3
- DEPRECATION WARNING: Calling `<<` to an ActiveModel::Errors message array in order to add an error is deprecated HOT 3
- [Rails 7.1] Association Validator Keyed by Association Name
- Can't edit classes on input elements. HOT 5
- Release new version (5.3.0) HOT 2
- new version 5.3.0 - undefined method `arity' for HOT 4
- V 5.3.1 - Using ruby's %w() array shortcut in bootstrap_form_for statement causes 'ActionView::Template::Error:' HOT 6
- Generate System Test Baseline via GitHub Actions
- Some Examples May Be Failing
- `collection_check_boxes` does not work with Rails 6.1 HOT 4
- Lazy load ActionText helpers HOT 10
- Overriding form tag's 'control_col' not working for f.check_box (layout: :horizontal)
- Need to use plain method for visibility with bootstrap_form in Phlex Component HOT 2
- render problem HOT 3
- Update Gemfiles?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap_form.