Label dosen't work in select field about bootstrap_form

[carloslopes]

Hi @extrim,

Thanks for open the ticket and this appears to be a bug, for a temporary workaround you can try to define your control this way:

f.select :year, options_for_select((1996..2014).to_a.reverse), nil, :label => 'Some label'

I think this will solve your problem for now, but I'll open an issue on the new repository[1] to fix this.

[1]: We are moving this repo to a new company, you can see more details here: https://github.com/bootstrap-ruby/rails-bootstrap-forms

[potenza]

@carloslopes lemme know what you think of this approach. If you think it's OK, I'll push a bug fix release today.

[carloslopes]

For me it's fine, but, I don't understand the necessity of these lines: https://github.com/potenza/bootstrap_form/blob/master/lib/bootstrap_form/form_builder.rb#L125-L131

IMHO, we should get the args passed to the method and extract from it the options after that we extract from the options the bootstrap related ones. These << calls are not clear for me 😕

[potenza]

I added those lines when I was having issues with passing options like include_blank: true or prompt: "Please Select" to select helpers. For instance, collection_select can be called like this (from our tests):

@builder.collection_select(:status, [], :id, :name)
@builder.collection_select(:status, [], :id, :name, prompt: "Please Select")
@builder.collection_select(:status, [], :id, :name, { prompt: "Please Select" }, class: "my-select")

It seemed simpler to 'normalize' the arguments rather than inspecting them to figure out what was sent over. I admit, it's not the clearest approach so I'm open to changing it to something that's easier to understand.

[potenza]

I was thinking that it might be cleaner to use a different define_method block for selects rather than messing with the args. I'll try this out.

[carloslopes]

@potenza this is related to my comment here: #8 (comment)