Coder Social home page Coder Social logo

Comments (4)

crftwrk avatar crftwrk commented on September 21, 2024

This came from the underscores boiler template.

Check https://dev.bootscore.me/2013/01/10/markup-image-alignment/, open console and remove it. Featured image gets crashed and all other images have fallback to:

html :where(img[class*=wp-image-]) {
  height: auto;
  max-width: 100%;
}

If you remove this as well, images will overflow the container:

screenshot

from bootscore.

smileBeda avatar smileBeda commented on September 21, 2024

Right, got that... but would it not be more adequate to add img-fluid to the markup of those images?
I understand the failsafe...

I guess I will just overwrite it in the scss - no big deal.

from bootscore.

crftwrk avatar crftwrk commented on September 21, 2024

Right, got that... but would it not be more adequate to add img-fluid to the markup of those images?

Yes, of course. The link above leads to the WP test data which are used by the WP theme reviewers. We have to check all images on this site. Quickly checked the offcanvas cart images, they affected as well for example.

from bootscore.

crftwrk avatar crftwrk commented on September 21, 2024

Double checked the boiler template, and this snippet is still present. Figured out that the img selector is used for the classic editor while html :where(img[class*=wp-image-]) is used in blocks.

Generate a theme on Underscores and check line 519 in style.css. Think we should not do there any changes.

from bootscore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.