scssphp won't compile anymore about bootscore

[justinkruit]

Thanks for this error report. Seems like we need to add a check if the bootstrap.min.css exists in the parent theme. This will be fixed in the upcoming 5.1.2.0 release.

[justinkruit]

Scss is based on order. For example this wouldn't work:

$colortest: $testtest;
$testtest: #000;

But this does:

$testtest: #000;
$colortest: $testtest;

Because _bscore_variables.scss is intended to override Bootstrap variables it's called before all the Bootstrap code. This results in all the Bootstrap variables not being set yet, so you can't call them yet.

[smileBeda]

This issue still happens on a vanilla install where you - without anything else first - activate the child theme.

The error now is:

Warning: : filemtime(): stat failed for /.../bootscore/wp-content/themes/bootscore-child-main/css/main.css in /.../bootscore/wp-content/themes/bootscore-child-main/functions.php on line 11

The error goes away if you first activate parent, then child theme.

[Lo1176]

Something else.
The scss import should not be placed in the last bootcommerce-child/css/scss/bootstrap.min.scss file but in bootcommerce-child/css/scss/_bscore_varies.scss.
I don't know why some of the new scss files were imported but not others.

Example, when I put :
// personal scss
@import "card";
@import "colors";
@import "font";
@import "home";
@import "svg";
in /css/scss/bootstrap.min.scss
=> _card.scss and _home.scss are loaded but not _colors.scss

But if I put everything in css/scss/_bscore_varaibles.scss, => everything loads ... mystery

Another question why for my colours I can't do:
$primary: $red;
but I have to do:
$primary: #dc3545;
This is not very practical if you want to use the variables ...

I've got this error message:

bootScore SCSS Compiler - Caught exception:

Undefined variable $red: wp-content/themes/bootcommerce-child/css/scss/_colors.scss on line 10, at column 1 Call Stack: #0 import wp-content/themes/bootcommerce-child/css/scss/_colors.scss wp-content/themes/bootcommerce-child/css/scss/_bscore_variables.scss on line 6 #1 import wp-content/themes/bootcommerce-child/css/scss/_bscore_variables.scss (unknown file) on line 1

[crftwrk]

bootScore SCSS Compiler - Caught exception:

Yes, because $red is not defined. Do this:

$red: #dc3545;
$primary: $red;

[Lo1176]

Ok, my bad.

As $red was already defined in bootstrap _variables.scss
$red: #dc3545 !default;
I didn't though I had to define it again.
Now I know my mistake.

Thanks 🙏

[justinkruit]

@Lo1176 Could you please try again with the changes made in commit b434af5?
As it originally is a warning only, it shouldn't actually have stopped creating the file in the child theme folder.
If it's not fixed with this commit, we can investigate further.

[Lo1176]

Sure I will. Le mer. 6 oct. 2021 à 16:00, Justin Kruit ***@***.***> a écrit :

…

Could you please try again with the changes made in commit b434af5 <b434af5> ? As it originally is a warning only, it shouldn't actually have stopped creating the file in the child theme folder. If it's not fixed with this commit, we can investigate further. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANQPKLAWMXWR33XKSEBWATTUFRI7TANCNFSM5FN467HQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[crftwrk]

Tested and works fine.

[Lo1176]

Hi,
It's working like a charm. 👍
In both Child or Parent Theme.
Thanks

[justinkruit]

Great to hear it's fixed now!

[oitconz]

This issue still happens on a vanilla install where you - without anything else first - activate the child theme.

The error now is:

Warning: : filemtime(): stat failed for /.../bootscore/wp-content/themes/bootscore-child-main/css/main.css in /.../bootscore/wp-content/themes/bootscore-child-main/functions.php on line 11

The error goes away if you first activate parent, then child theme.

I would like to second this. The fix is to activate parent theme then activate child theme BUT - I had the parent theme in play. Uploaded ( via ftp) the child theme then activated it. This required a second round of deactivate child, reactivate parent, reactivate child.

The issue is the child them does not have a /css folder and no /css/main.css file so the stat fails.

[crftwrk]

Before reopen this issue, tested it quickly on localhost. Error appears on first page load, but it's gone when reloading the page.