Coder Social home page Coder Social logo

Comments (4)

atomashpolskiy avatar atomashpolskiy commented on July 17, 2024

In fact, for SingleJob the best way would be to replace

public JobMetadata getMetadata() {
    return delegate.getMetadata();
}

with

public JobMetadata getMetadata() {
    return merge(execution.getParams(), delegate.getMetadata());
}

from bootique-job.

andrus avatar andrus commented on July 17, 2024

This seems to muddle the distinction between job singleton parameters and parameters of a given job run. Whether this is important or not, I have no idea yet.

from bootique-job.

andrus avatar andrus commented on July 17, 2024

After discussing offline, it actually makes sense, as "execution" is simply a param set.

from bootique-job.

andrus avatar andrus commented on July 17, 2024

While this issue is still something that we will need to address, it begs a bigger question on the distinction between a job and an execution, and will probably result in refactoring Job API (e.g. base metadata can be gathered from annotations, while execution metadata may be passed to the "run" method). So closing this task, as we won't be implementing it as described.

from bootique-job.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.