Coder Social home page Coder Social logo

Comments (4)

PlacidBox avatar PlacidBox commented on June 27, 2024

Did some digging and that commit to libcxxabi looks like it was included in clang4. Here's the patch I'm currently using. It might break some users that aren't using libcxxabi though.. not really too sure on the best way to handle this.

--- boost/config/stdlib/libcpp.hpp	2018-07-26 10:09:30.091065048 +1000
+++ boost/config/stdlib/libcpp.hpp	2018-07-26 10:14:24.641990321 +1000
@@ -113,10 +113,16 @@
 #  define BOOST_NO_CXX11_THREAD_LOCAL
 #endif
 
-#if defined(__linux__) && !defined(BOOST_NO_CXX11_THREAD_LOCAL)
+#if defined(__linux__) && _LIBCPP_VERSION < 4000 && !defined(BOOST_NO_CXX11_THREAD_LOCAL)
 // After libc++-dev is installed on Trusty, clang++-libc++ almost works,
 // except uses of `thread_local` fail with undefined reference to
 // `__cxa_thread_atexit`.
+//
+// clang's libc++abi provides an implementation by deferring to the glibc
+// implementation, which may or may not be available (it is not on Trusty).
+// clang 4's libc++abi will provide an implementation if one is not in glibc
+// though, so thread local support should work with clang 4 and above as long
+// as libc++abi is linked in.
 #  define BOOST_NO_CXX11_THREAD_LOCAL
 #endif
 

from config.

jzmaddock avatar jzmaddock commented on June 27, 2024

Confirmed as working with Ubuntu clang-6 packages at least.

from config.

jzmaddock avatar jzmaddock commented on June 27, 2024

Spoke too soon.... failed CI testing with clang-5. Updating the CI tests and waiting for them to cycle...

from config.

jzmaddock avatar jzmaddock commented on June 27, 2024

CI is passing now, not sure if we have all the wrinkles sorted, but it's better than it was.

from config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.