Comments (5)
So just to make sure, this is in reference to the web content used for test cases that we have? Would something like moving the tests out of the actual package help/hurt the cause? We could try to 'make up' content that fits the test case, but it's obviously important that once we hit a bug it's easy/best to get that content and make sure we parse it correctly.
from breadability.
On Sat, Apr 12, 2014 at 10:36:24AM -0700, Rick Harding wrote:
So just to make sure, this is in reference to the web content used for test cases that we have? Would something like moving the tests out of the actual package help/hurt the cause? We could try to 'make up' content that fits the test case, but it's obviously important that once we hit a bug it's easy/best to get that content and make sure we parse it correctly.
Yep, it's about the web content. Moving it out of the actual package
would help a lot, because that means I can just package the upstream
source without the tests.
Making up contents would be ideal (because it means I can still run
the tests for every package build), but I'm guessing is also the most
work.
Cheers,
Jelmer
from breadability.
Ok cool, I'll try to pull the tests out as that'll be fast and unblock you and then can see if we can mimic the issue the site gave us and replicate it in a 'generic' way as follow ups.
from breadability.
I've uploaded 0.1.20 that does not include the tests in the source build. We'll keep that as a pure development tool for now and use in CI while we try to find a better way to generate test files that aren't copyrighted material.
from breadability.
Thanks!
from breadability.
Related Issues (20)
- None type error in readable parsing
- lazy loaded images aren't pulled in HOT 7
- Missing argparse in requirements HOT 1
- issue parsing NYT article missing first paragraph
- Readable version is missing images HOT 1
- site should all content when none is found for readable parsed
- Wrong content picked HOT 3
- Using AdBlock rules to remove elements
- Single invalid character results in a failed parse. HOT 1
- move tests to pytest like bookie HOT 1
- Missing section headings
- Article fail to pick some content HOT 1
- Bookie tests failing; need to fix installation for Travis CI HOT 5
- Python 3.7 compatible release? HOT 6
- not all nodes are scored/removed in the prep_article phase. HOT 1
- utf 8 issue HOT 2
- error dropping node HOT 2
- TypeError: decode() argument 1 must be string, not Non HOT 1
- exceptions with bad parsing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from breadability.