Comments (13)
BTW: I've read your homepage and searched for other mentions of your name. I have learned a lot. Thanks for all your impressive work
from pcodedmp.
I just checked, there is a better way to edit the requirements in setup.py using "Environment Markers" as specified in PEP-508: https://stackoverflow.com/a/54281345/4405656
from pcodedmp.
I'd do this in the develop
branch, if necessary (I don't think that just this change requires a new version release), but why is it necessary? I've installed both the tool and the win_unicode_console
module on Linux and they work just fine there. I assume the module just does nothing on Linux.
from pcodedmp.
I've checked the code of win_unicode_console
, it has the same if platform.system().lower() == "windows":
checks. So you are right, the module does nothing.
However, not everybody has the luxury of having pip or other tools install all required modules for them. In my setup, I have to download, package and install all required modules myself. That is a bit of an effort and I would like to avoid it for something that I know I will not need anyway.
So, maybe my remark about "many oletools linux users" may have been too strong, most people will never notice this since pip just does the work for them. However, I am sure I am not the only one not using pip or finding it strange to install a windows-specific module on their linux machine.
And after all it is just a small change...
from pcodedmp.
Actually there is another issue related to win_unicode_console: it is not supported on Pypy (on Windows), and triggers an error. I will propose a change so that pcodedmp simply ignores it when win_unicode_console cannot be imported.
from pcodedmp.
I'll do it, at least based on the principle that I'd rather not install a module somewhere if I can avoid it, but even if you aren't using pip
, can't you just do python setup.py install
after downloading the project?
It's not just a configuration change, BTW. I'd have to modify the source of the main script too and not try to import or use the win_unicode_console
module when not running on Windows.
OK, I think I've made the necessary changes. Please try the develop
branch and tell me if it now works as you wanted.
from pcodedmp.
Perfect, thanks very much!
Keeping dependencies to a minimum in general is also a very good motive.
And to anwer your question: for my own machine I could just do setup.py install. But I have to distribute the package to several machines and we are using rpm for that, so I have to create an rpm with a few modifications, which is quite a bit more effort.
Issue solved for my part
from pcodedmp.
:) Yeah, I used to be a big name in the anti-virus field when I was young. Still got a few moves, though. :)
OK, I won't be closing the issue just yet, because @decalage2 has some additional modifications in mind, in order to make the project compatible with PyPy.
from pcodedmp.
I propose to close this one and I'll open another one for the Pypy issue. It's related, but not the same.
from pcodedmp.
OK, closed.
from pcodedmp.
May I ask when you plan on merging this into master?
from pcodedmp.
I was waiting for @decalage2's modifications for PyPy compatibility. Merged now, version 1.2.6 released.
from pcodedmp.
I see. Thank you!
from pcodedmp.
Related Issues (15)
- Wrong object names HOT 15
- Cross comparison with Open Office HOT 12
- Error: unpack_from requires a buffer of at least 4 bytes HOT 4
- Python 2.7 support broken HOT 2
- pcodedmp can't be installed in either Ubuntu and Windows 10 HOT 2
- pcodedmp can't disassemble VBA code HOT 5
- Redundant parens in README sample code HOT 1
- A mysterious question, where is the pcode document? HOT 2
- license question HOT 1
- Remove cycle between oletools and pcodedmp HOT 1
- Code Review
- Support for MS Access' `Option Compare Database` HOT 1
- Website installation instructions are incomplete HOT 5
- Error: unpack_from requires a buffer of at least 2 bytes. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pcodedmp.