Incremental build failed about bob

[rhubert]

I don't think this is a bug? After reverting the changes you can reuse the result from the first build and that's why bob doesn't need to execute build/package step.

[jkloetzke]

I thought the same but it is actually not true. When running the build step it could do a rm -rf as a first command. Then it fails and leaves no result in the work space. At step 3 Bob has to run the build step again or the package step will grab into the stale result from step 2.

[rhubert]

But the package step isn't executed in 3?

binary-repository $ bob dev root
>> root
>> root/lib
   DOWNLOAD  dev/dist/lib/1/workspace...[Errno 111] Connection refused
   CHECKOUT  dev/src/lib/1/workspace
   BUILD     dev/build/lib/1/workspace
   PACKAGE   dev/dist/lib/1/workspace
>> root
   CHECKOUT  dev/src/root/1/workspace
   BUILD     dev/build/root/1/workspace
   PACKAGE   dev/dist/root/1/workspace
Build result is in dev/dist/root/1/workspace

-> edit dev/src/lib/1/workspace/lib.c

binary-repository $ bob dev root>> root
>> root/lib
   CHECKOUT  skipped (fixed package dev/src/lib/1/workspace)
   BUILD     dev/build/lib/1/workspace
/home/biera/projects/bob/bob-tutorials/binary-repository/dev/src/lib/1/workspace/lib.c: In function 'foo':
/home/biera/projects/bob/bob-tutorials/binary-repository/dev/src/lib/1/workspace/lib.c:5:2: error: unknown type name 'p'
  p rintf("Hello world!\n");
  ^
/home/biera/projects/bob/bob-tutorials/binary-repository/dev/src/lib/1/workspace/lib.c:5:10: error: expected declaration specifiers or '...' before string constant
  p rintf("Hello world!\n");
          ^
Step failed on line 17: Exit status 1; Command: gcc -c -o lib.o $1/lib.c
Build error: Build script ./dev/build/lib/1/build.sh returned with 1
Processing stack: root/lib
You may resume at this point with '--resume' after fixing the error.

revert

binary-repository $ bob dev root
>> root
>> root/lib
   CHECKOUT  skipped (fixed package dev/src/lib/1/workspace)
   BUILD     skipped (unchanged input for dev/build/lib/1/workspace)
   PACKAGE   skipped (unchanged input for dev/dist/lib/1/workspace)
>> root
   CHECKOUT  skipped (fixed package dev/src/root/1/workspace)
   BUILD     skipped (unchanged input for dev/build/root/1/workspace)
   PACKAGE   skipped (unchanged input for dev/dist/root/1/workspace)
Build result is in dev/dist/root/1/workspace

[jkloetzke]

Hmm, you're right. This simple example is not enough. Somehow it did run the package step when I encountered the problem today. 🤔

[jkloetzke]

I got a repro case though it was certainly not the one I had today:

1. build

$ bob dev root
>> root
>> root/lib
   DOWNLOAD  dev/dist/lib/1/workspace...[Errno 111] Connection refused
   CHECKOUT  dev/src/lib/1/workspace
   BUILD     dev/build/lib/1/workspace
   PACKAGE   dev/dist/lib/1/workspace
>> root
   CHECKOUT  dev/src/root/1/workspace
   BUILD     dev/build/root/1/workspace
   PACKAGE   dev/dist/root/1/workspace
Build result is in dev/dist/root/1/workspace

2. insert error in lib.c and rebuild clean:

$ bob dev root --clean
>> root
>> root/lib
   CHECKOUT  skipped (fixed package dev/src/lib/1/workspace)
   BUILD     dev/build/lib/1/workspace
/home/jkloetzke/src/bob/bob-tutorials/binary-repository/dev/src/lib/1/workspace/lib.c: In function 'foo':
/home/jkloetzke/src/bob/bob-tutorials/binary-repository/dev/src/lib/1/workspace/lib.c:5:2: error: unknown type name 'p'
  p rintf("Hello world!\n");
  ^
/home/jkloetzke/src/bob/bob-tutorials/binary-repository/dev/src/lib/1/workspace/lib.c:5:10: error: expected declaration specifiers or '...' before string constant
  p rintf("Hello world!\n");
          ^~~~~~~~~~~~~~~~
Step failed on line 17: Exit status 1; Command: gcc -c -o lib.o $1/lib.c
Build error: Build script ./dev/build/lib/1/build.sh returned with 1
Processing stack: root/lib
You may resume at this point with '--resume' after fixing the error.

3. revert and change lib.yaml packageScript to force re-execution of package step:

$ bob dev root --clean
>> root
   PRUNE     dev/dist/root/1/workspace (recipe changed)
>> root/lib
   PRUNE     dev/dist/lib/1/workspace (recipe changed)
   DOWNLOAD  dev/dist/lib/1/workspace...[Errno 111] Connection refused
   CHECKOUT  skipped (fixed package dev/src/lib/1/workspace)
   BUILD     skipped (unchanged input for dev/build/lib/1/workspace)
   PACKAGE   dev/dist/lib/1/workspace
cp: cannot stat '/home/jkloetzke/src/bob/bob-tutorials/binary-repository/dev/build/lib/1/workspace/lib.o': No such file or directory
Step failed on line 17: Exit status 1; Command: cp -a $1/lib.o .
Build error: Build script ./dev/dist/lib/1/package.sh returned with 1
Processing stack: root/lib