Comments (9)
Can you provide a PR and a test case?
from bndtools.
from bndtools.
Look at aQute.bnd.repository.osgi.OSGiRepositoryTest
in biz.aQute.repository
project (test
folder. The testRepo()
test is testing refresh.
from bndtools.
If I understand correctly testPollingWithFile
tests whether or not the repo refreshes based on the polling interval, testBndRepo
tests whether getIndex(true) starts a task. Is this correct [not familiar with the bndtools codebase (yet), thanks for any support]?
I can implement a new test case that tests that refreshing actually refreshes the repository, that must be doable.
from bndtools.
It is a long time ago ... just play with the code and see what happens :-)
from bndtools.
OK, will do, will take a while though.
from bndtools.
Oh come on, you got the whole evening! :-)
from bndtools.
I wrote a test case for what I think might be the problem, i.e. the index not being updated on refresh. You can find it at jellenelis/bnd@04d14e4. It basically just updates the index (as seen in one of the other tests and checks whether or not the cache of the OSGiIndex actually changes. With the original code, it fails, using true
for refresh
actually makes the test case pass.
This seems nice, but I saw that there are RepositoryListenerPlugin
s that would like to be notified whenever a repository is refreshed. I would think they would need to be notified when the user refreshes the repositories as well, or is this not necessary? I did not find a straightforward way to be able to notify them. Depending on your feedback, I might consider adding support for that as well.
from bndtools.
You can look on MavenBndRepository.refresh()
how the notifying of the repository listeners goes
I think you should get the Promise from the OSGiIndex that getIndex created and then on the callback when the promise is satisfied you notify the listeners.
from bndtools.
Related Issues (20)
- [Bndtools 4.0.0.REL] Error querying repository Central. java.lang.NullPointerException HOT 4
- [Bndtools 4.0.0.REL] Require-Capability: osgi.extender change the minVersion HOT 6
- Eclipse Java Editor cannot not see class inheritance from jdo-enhanced classes in Bndtool project HOT 4
- Remove dead code
- Existing Bnd Workspace import should set classpath settings for test directory in Photon
- Problem with testpath resolution in Bndtools Alpha HOT 2
- Continuous Integration tests don't run continuously HOT 2
- Add support for start levels in bndtools launcher HOT 3
- runproperties are not copied to lanucher HOT 1
- Runtime Classpath is transitive HOT 10
- report unused buildpath and testpath entries HOT 6
- ${if} macro not working correctly in some condition HOT 1
- Template Repository preference validates irrespective of Branch
- Bndrun file editor shows raw filter string HOT 8
- Impossibility to add an exact version of a bundle in bndrun file editor
- Bndrun file editor should allow for run bundles reordering
- Error at end of resolve if bndrun editor closed during resolution HOT 2
- Fragment Requirements Not Shown
- On Java 11 bnd issues many HttpClient processes do download JRE classes such as `Download jrt:/java.base/java/lang/Iterable.class` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bndtools.