OSGiRepository does not seem to refresh when "Refresh Repositories" or "Refresh Repositories Tree" is pushed about bndtools

[pkriens]

Can you provide a PR and a test case?

[jellenelis]

I can provide a pull request, but I have no idea how to test this in code. Could you provide me with some pointers on how that could be done?

…

On 30-08-18 11:32, Peter Kriens wrote: Can you provide a PR and a test case? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1930 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEhwDewIAJpG6cSjp9m50JD_ZsGYqxePks5uV7EygaJpZM4WTEzE>.

[pkriens]

Look at aQute.bnd.repository.osgi.OSGiRepositoryTest in biz.aQute.repository project (test folder. The testRepo() test is testing refresh.

[jellenelis]

If I understand correctly testPollingWithFile tests whether or not the repo refreshes based on the polling interval, testBndRepo tests whether getIndex(true) starts a task. Is this correct [not familiar with the bndtools codebase (yet), thanks for any support]?

I can implement a new test case that tests that refreshing actually refreshes the repository, that must be doable.

[pkriens]

It is a long time ago ... just play with the code and see what happens :-)

[jellenelis]

OK, will do, will take a while though.

[pkriens]

Oh come on, you got the whole evening! :-)

[jellenelis]

I wrote a test case for what I think might be the problem, i.e. the index not being updated on refresh. You can find it at jellenelis/bnd@04d14e4. It basically just updates the index (as seen in one of the other tests and checks whether or not the cache of the OSGiIndex actually changes. With the original code, it fails, using true for refresh actually makes the test case pass.

This seems nice, but I saw that there are RepositoryListenerPlugins that would like to be notified whenever a repository is refreshed. I would think they would need to be notified when the user refreshes the repositories as well, or is this not necessary? I did not find a straightforward way to be able to notify them. Depending on your feedback, I might consider adding support for that as well.

[pkriens]

You can look on MavenBndRepository.refresh() how the notifying of the repository listeners goes

I think you should get the Promise from the OSGiIndex that getIndex created and then on the callback when the promise is satisfied you notify the listeners.