Coder Social home page Coder Social logo

own ID as parent ID exception about tree HOT 1 CLOSED

vikyd avatar vikyd commented on August 15, 2024
own ID as parent ID exception

from tree.

Comments (1)

BlueM avatar BlueM commented on August 15, 2024

The reason I didn’t use === is that one the one hand, I would not have expected mixed datatypes for the IDs, but also as it might impose more work on users to make the input data type-safe.

However, if string IDs and numeric IDs are used in the same dataset, this is of course a bug. Thanks for reporting. On the other hand, simply using === in my opinion is not the optimal solution, as you can construct cases where the invalid parent reference might not be detected. See a75b2f7#diff-d6a892aa7d058c8f3e87ef9717e5cf4bR300 for a test where === would fail. Instead, I chose to use (string) typecasting plus ===; the test is here: a75b2f7#diff-d6a892aa7d058c8f3e87ef9717e5cf4bR313

One more remark: when submitting a pull request, you should not change the project’s name in composer.json.

from tree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.