Coder Social home page Coder Social logo

Comments (13)

h-vetinari avatar h-vetinari commented on June 3, 2024 1

Ah wait, I just see this happens on MacOS 13, which is way newer than 10.13. Presumably extra_compile_args.append("-mmacosx-version-min=10.9") needs to be bumped?

from turbodbc.

david-engelmann avatar david-engelmann commented on June 3, 2024 1

@jmao-denver @devinrsmith 11.0 is perfect, if we wanted to try to build with it set 10.13 that would be the most conservative. Originally, I just said try with 13 to confirm that's the issue. I believe @h-vetinari addressed in conda stock

from turbodbc.

david-engelmann avatar david-engelmann commented on June 3, 2024

Are you using c++17 and High Sierra or greater?

from turbodbc.

david-engelmann avatar david-engelmann commented on June 3, 2024

Similar issues in the feedstock repo

from turbodbc.

h-vetinari avatar h-vetinari commented on June 3, 2024

This can be fixed in conda-forge (because we ship our own, current libcxx), but regular users will have to update their MacOS SDK.

from turbodbc.

jmao-denver avatar jmao-denver commented on June 3, 2024

To answer @david-engelmann, yes, the compiler flag is actually already set to use c++17 and my clang is version 14.0.0.

from turbodbc.

david-engelmann avatar david-engelmann commented on June 3, 2024

Ah wait, I just see this happens on MacOS 13, which is way newer than 10.13. Presumably extra_compile_args.append("-mmacosx-version-min=10.9") needs to be bumped?

This seems to be the issue

from turbodbc.

david-engelmann avatar david-engelmann commented on June 3, 2024

@jmao-denver adjusting the compile args in setup.py to -mmacosx-version-min=13.0 should help, I'm not on a mac so I'm not able to confirm

from turbodbc.

devinrsmith avatar devinrsmith commented on June 3, 2024

MacOS 13.0 is very new; I think trying to set a more conservative version would be appropriate.

from turbodbc.

jmao-denver avatar jmao-denver commented on June 3, 2024

@david-engelmann With -mmacosx-version-min=11.0, I am able to build and test successfully on MacOS 13, and I agree with @devinrsmith on being conservative with minimum version support.

from turbodbc.

hkad98 avatar hkad98 commented on June 3, 2024

Hi,
@no23reason opened a pull request bumping mmacosx-version-min to 11.0, fixing the error above. Could someone have a look at that, please?

cc: @xhochy

from turbodbc.

jmao-denver avatar jmao-denver commented on June 3, 2024

@david-engelmann Any idea whether this fix will be included in v4.5.7 and if yes, when v4.5.7 might be coming out?

from turbodbc.

david-engelmann avatar david-engelmann commented on June 3, 2024

@jmao-denver It seems like there are two open prs that need to be merged in to fix everything, @xhochy is the best person to ask this. There is a issue with macos sim links with brew installing that had paused my work on adding in multiple os testing

from turbodbc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.