Coder Social home page Coder Social logo

Comments (5)

IonicaBizau avatar IonicaBizau commented on May 20, 2024

Hmm, right.

It should be fixed here–if the response doesn't contain svg stuff (or svg contribution squares), then run that request again. 🔮

from github-calendar.

palmerev avatar palmerev commented on May 20, 2024

To me, this looks the same as before.

cal.querySelector(".left.text-muted").innerHTML = options.summary_text;

The .left.text-muted element always shows up, regardless of whether the spinner or the svg grid loads,
so I don't think this fixes it. The version on my fork recursively repeats the fetch until the svg loads.
I'd like to submit a pull request if that's ok.
UPDATE: the code should probably do a second setTimeout before requesting again. I'll change it soon.

from github-calendar.

IonicaBizau avatar IonicaBizau commented on May 20, 2024

@palmerev Interesting. The code looks good. But like you said, a timeout would be good.

Also, this check should be moved here, meaning, do not change the HTML unless we got the calendar. 💫

from github-calendar.

palmerev avatar palmerev commented on May 20, 2024

This has the timeout and moves the check to before the HTML update.

Also, side question: How do you highlight lines in files like you're doing in your comment? I see line numbers added to the URL, but is there another way?

from github-calendar.

IonicaBizau avatar IonicaBizau commented on May 20, 2024

@palmerev Nice work! ✨

You have to click the line number. If you want to select multiple lines, hold shift and click another line to select a range. 🚀

from github-calendar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.