About bilinear cursor upscaling in recent versions about magpie

[Blinue]

Thank you for the feedback! The cursors in these games are what’s known as “monochrome cursors”. According to the documentation, they only have four states, so bilinear interpolation doesn’t make sense for them. If you’re interested, here is the code for drawing them.

Magpie/src/Magpie.Core/EffectCompiler.cpp

Lines 1240 to 1250 in b536d95

	if( mask.x > 0.5f) {
	if (mask.y > 0.5f) {
	color = 1 - color;
	}
	} else {
	if (mask.y > 0.5f) {
	color = float3(1, 1, 1);
	} else {
	color = float3(0, 0, 0);
	}
	}

The new version is actually more “correct,” but the outcome doesn’t align with user expectations: the cursor seems don’t adhere to the “bilinear interpolation” option, so I consider this a bug rather than a feature, and I plan to fix it in the next release.

[BG-Mania]

I'm appreciate you taking this into consideration. :)

[Blinue]

Does this build fix the issue?

https://github.com/Blinue/Magpie/actions/runs/8342762488/artifacts/1338693167

[BG-Mania]

I'm so sorry. It's obviously much better than before, but I still feel like 0.8.0 is better. 😅
It's fine when upscaling 640x480 and 1024x768, but 800x600 is the exception.

[Blinue]

I’ve resolved the issue within the development branch, and this particular fix will not be backported to v0.10. Should you wish to test it immediately, the development build is available for download here. To prevent any overwriting of the global configuration files, it’s advisable to turn on portable mode.

[BG-Mania]

PERFECT! Thank you for your efforts. You're a Hero of old-school gamers. 😃

[Blinue]

Thank you for your feedback and testing. Have a blast playing!