Coder Social home page Coder Social logo

Comments (5)

lightning-auriga avatar lightning-auriga commented on June 9, 2024

I'll add some assorted comments here, in addition to the above:

  • first sentence contains broad generalization (e.g. in most cases) that I think weakens the presentation overall. that can be addressed later, and should involve specific examples
  • direct reference to existing tools e.g. marginal models is essential here; certainly GLMs are a major offender here, but I think being as precise as possible strengthens the assertion that the package is needed
  • I mention this in the vignette issue as well, but I think defining what is meant by asymptotically here is important: how can we evaluate if our data and models are appropriate for this package, or that we can expect reasonable convergence?
  • the background section contains non-background content that is best included elsewhere or pared down
  • how are guarantees in line 75 being proven? it seems like this in part relies on behavior of sl3. in any case, these guarantees should be elaborated upon

from cvtreemle.

lightning-auriga avatar lightning-auriga commented on June 9, 2024

In terms of the review checklist, I think the two points description [...] for a diverse, non-specialist audience and clearly states [...] who the target audience is could both use further elaboration and expansion. The author is very clearly knowledgeable about the methodology in use here. I think the target audience would likely be users of standard marginal models (e.g. GLM), but observe that many such users are specifically using GLMs because they understand basic regression models but are perhaps not as comfortable with more advanced ML techniques. I think including some content that specifically reaches out to such users, if indeed they are part of the intended user set, would be most welcome.

from cvtreemle.

blind-contours avatar blind-contours commented on June 9, 2024

@GaryBAYLOR I have made edits to the paper based on your comments. @cpalmer718 I have done some rewriting to reference existing methods and lay a quick but better foundation as to the methodological gap this method/software is filling. I've added some additional details as to asymptotic convergence and under what assumptions we have an efficient rate of convergence. I have also rewritten sections of the background.

from cvtreemle.

GaryBAYLOR avatar GaryBAYLOR commented on June 9, 2024

@blind-contours Looks good. Just one very minor comment, be consistent in writing nonparametric, either non-parameter or nonparametric is okay (line 18, 19, 30, 44)

@cpalmer718 I'm good on my comments. Please feel free to close the issue when the questions in your comments are addressed.

from cvtreemle.

blind-contours avatar blind-contours commented on June 9, 2024

I've updated the md document to be consistent in using non-parametric.

from cvtreemle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.