CockroachDB Dialect Implementation about blaze-persistence

[morphace]

Done: #1809

[beikov]

Hi there.
Nobody requested support for CockroachDB yet, so that's why Blaze-Persistence has no built-in support :)
We can treat it like PostgreSQL for the purpose of function registration and so on, but since it takes a lot of time and effort to setup and maintain automated testing, I hope you understand that there will never be "first class" support like for other databases. This would be a best effort thing.

[morphace]

Hi! Ok - what I could try to do is to check how it does with PG set as dialect. However it seems to auto-detect the dialect from the JPA one? Is there a way to override the auto-detected dialect?

[beikov]

The Hibernate integration detects the database based on the configured dialect. If your dialect extends the PostgreSQLDialect, it is considered a PostgreSQL variant.

[morphace]

That's what I expected - but I use CockroachDB192Dialect which is not derived from PostgreSQLDialect . Therefore, I'll try to find a way to set the dialect for blaze persistence manually, if there is one at all?

[beikov]

It seems that we detect CockroachDB already, but don't do functions registrations for it yet. See https://github.com/Blazebit/blaze-persistence/blob/main/integration/hibernate-base/src/main/java/com/blazebit/persistence/integration/hibernate/base/function/AbstractHibernateEntityManagerFactoryIntegrator.java#L185C26-L185C26

I'd very much appreciate if you could create a PR that just copies all the lines containing "postgresql" and replaces with "cockroach": https://github.com/Blazebit/blaze-persistence/blob/main/core/impl/src/main/java/com/blazebit/persistence/impl/CriteriaBuilderConfigurationImpl.java#L582

[morphace]

excatly, that's what i thought could work...

[morphace]

Updated according suggestions

[beikov]

Fixed via 178a9f6