Coder Social home page Coder Social logo

Comments (7)

robfuscator avatar robfuscator commented on September 27, 2024 1

Nope, but comma-separated lists of paths are allowed :)

Wonderful!

What about supporting files and paths in all pragmas and renaming @miscDir to @assets in the long term, along with @audioAssets, ..., or the like (naming is hard)? I don't really see the need for another pragma then.

Yes, I like that idea. I think it's more clear than misc and Dir. Also, this would leave users with the option to use your predefined assets structure, but also enable them to create their own structure from scratch using just @assets. (I guess with the current solution this is already possible for asset directories, but not very intuitive.)

from jspsych-builder.

bjoluc avatar bjoluc commented on September 27, 2024

Good point. I think the reason that @miscDir doesn't work here is that it only accepts directories and replicates the provided path in the study assets directory. We would need a way to specify files here as well, so you could have @miscDir endPage.html, which would still be pretty confusing due to the "dir". I don't particularly like the "Dir" pragma names anyway and think they should also support files. We can only rename them in the next major release though, so it may be best to keep the names for now and start supporting file paths in a minor release. WDYT?

from jspsych-builder.

robfuscator avatar robfuscator commented on September 27, 2024

Sounds like a good solution to me.

Is it allowed to specify the same pragma multiple times? Otherwise only those who didn't use the @miscDir pragma already would benefit from the new feature.

Another option I can think of would be the introduction of a general @asset pragma to include files of any kind on the root level of the assets directory. But I'm not sure if this would bring any benefit over the existing audio-images-video-misc-structure.

from jspsych-builder.

bjoluc avatar bjoluc commented on September 27, 2024

Is it allowed to specify the same pragma multiple times? Otherwise only those who didn't use the @miscDir pragma already would benefit from the new feature.

Nope, but comma-separated lists of paths are allowed :) Again, the "Dir" is pretty confusing here... Should rather be "Dirs" right now.

Another option I can think of would be the introduction of a general @asset pragma to include files of any kind on the root level of the assets directory. But I'm not sure if this would bring any benefit over the existing audio-images-video-misc-structure.

What about supporting files and paths in all pragmas and renaming @miscDir to @assets in the long term, along with @audioAssets, ..., or the like (naming is hard)? I don't really see the need for another pragma then.

from jspsych-builder.

bjoluc avatar bjoluc commented on September 27, 2024

Even better maybe: Deprecating all "Dir" pragmas and introducing only @assets which resolves all dir/file paths from the root directory and detects media types on a per-file basis! You're absolutely right that the current solution is not very intuitive.

from jspsych-builder.

robfuscator avatar robfuscator commented on September 27, 2024

Sounds very streamlined and convenient to me. Looking forward to this 🚀.

from jspsych-builder.

github-actions avatar github-actions commented on September 27, 2024

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from jspsych-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.