Does it support for custom tar a package about exrm

[bitwalker]

@jsvisa How are you accessing the config files in etc from your release? The convention in Elixir projects is to store custom one-off files in priv, which will then be available in lib/myapp-<version>/priv in the release package. Is there a particular reason you don't want to follow that convention?

[jsvisa]

@bitwalker At the beginning of the app's booting, it will read the config file in etc directory, and these custom config will not put into Application.env, but a single Process contains all those configs. I put those config in this directory just because the operator can modify the file directory, If in lib/myapp-/priv, the path is to deep, but in etc directory, it's clearly.

[bitwalker]

I think my approach to this will be to add a helper function for adding files to the myapp-<version>.tar.gz file from plugins, using the after_release callback. You can then create a simple plugin to add additional files to that package as needed. This has the added benefit of being more flexible by giving you full control over what files are added, and how they are added (for instance you could add binary data directly to the package, while transforming it along the way).

Sound good to you?

[ericmj]

I think exrm should follow OTP conventions, if you don't want to follow OTP conventions you can modify the release after exrm created it.

[bitwalker]

@ericmj I agree, which is why I won't be supporting this via exrm directly. I already have code which manipulates the release package though, so exposing that to plugin authors leaves it up to them whether they wish to adhere to those principles or do something custom like this.

[jsvisa]

@bitwalker I'm sorry, after_release callback couldn't do anything. because execute_after_hooks is invoked before update_release_packageL71, the later creates the tar package L337 . In my opinion, should execute_after_hook invoked after update_release_package, this following the literal meaning of after_release

[bitwalker]

@jsvisa This is a proposed change to allow it to work. The tar file can always be modified after it's created, and I can change the time at which it's built as well. So in theory, what I'm asking is if adding the ability to add files to the tar in after_release is an acceptable fix for you?

[jsvisa]

@bitwalker Yeah, this could works, Thanks:)

[tsloughter]

If etc is listed in the overlay then it will be included in the tar file. This was a bug in relx before but was fixed in August, erlware/relx@e3842ab

[bitwalker]

@tsloughter I'll have to update my relx dependency to grab that fix. As it stands I need to pull in relx as a lib rather than as an executable anyways, so this might be the time to do that.

[tsloughter]

Cool. Let me know if there is anything I can do to help with that.