Comments (5)
from libutp.
bool
is defined (conditionally) in utypes.h not utp.h. So that's one thing to address first.
Next, what is __bool_true_false_are_defined? Finally, utp.cpp itself is C++ obviously, so there's no pressing need to define true
and false
in the header.
from libutp.
__bool_true_false_are_defined is a macro from stdbool.h to detect whether those keywords have already been defined.
The issue is that the compiler isn't smart enough to understand that the different typedefs from utypes.h, stdbool.h, and elsewhere are really the same unsigned char, so compilation fails with a mismatch.
Including stdbool.h in the not-C++ block of utypes.h would fix this. I don't know how universal stdbool.h is on your target platforms, but you could possibly drop the HAVE_STDBOOL_H autoconf idiom.
from libutp.
Certainly there is no stdbool.h on Windows. Also we don't have autoconf to set HAVE_STDBOOL_H.
Any easy answer here would be just use ints. That seems unlikely to bite me again (#12).
Why does the state of C89/C99/C++ have to be so terrible?
from libutp.
Blah, I forgot about #12.
int sounds like it might be the least-bad choice.
from libutp.
Related Issues (20)
- Assertion `mtu_floor <= mtu_ceiling' failed. HOT 2
- reserved identifier violation
- Remove an unnecessary null pointer check HOT 1
- Compilation broken on Windows with `utp_shutdown` changes HOT 1
- utp_socket memory can be leaked
- ECN support
- uTP Fast Open
- How to distinguish whether other peers use utp or tcp protocol? HOT 1
- Client socket must send data first HOT 2
- Question about UTPSocket::cur_window_packets initialization. HOT 2
- How to just the package of utp ? HOT 2
- Unable to build on Haiku HOT 1
- Question: performance figures HOT 4
- Tag releases for downstream packaging
- Assertion `mtu_floor <= mtu_ceiling' failed
- how to identify utp HOT 4
- Is there any format spec for utp version 0?
- libutp in a multi-thread application
- Member access within misaligned address for type 'UTPSocketKeyData', which requires 8 byte alignment HOT 1
- fast_resend_seq_nr not initalize for utp client
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libutp.