Breaks superagent about bitgojs

[olalonde]

Nevermind! the problem was with another module

[olalonde]

Oh the issue is that both bitgojs and my tests are using the supertest-as-promised module and this hangs one of my test for some reason.

[olalonde]

Ah, I guess this is the problem:

BitGoJS/src/bitgo.js

Line 30 in a8bec7b

superagent.Request.prototype.end = function() {

[olalonde]

Requiring Bitgo will break any app that uses superagent, maybe there would be a more elegant way to do this than patching superagent globally?

[bpdavenport]

Thanks for debugging. Is there a way you can work around this for the moment? Is bitgo not installing its own version of superagent, because you have it installed as a peer dependency? Can you force bitgo to install its own superagent that would then not conflict? Perhaps maybe if we changed the version from ^1.4.0 to "1.4.0", then you could depend on a different version, which would force it to be installed.

[bpdavenport]

We will look at how to make this cleaner, but it may take a bit.

[olalonde]

Yes, it's using the superagent I have already npm installed.

$ node --version
v6.0.0
$ npm --version
3.8.6

[olalonde]

As a quick fix, I think changing ^1.4.0 to "1.4.0" or if you published a fork of superagent under bitgo-superagent

[olalonde]

FWIW, Superagent will ship with promises soon: ladjs/superagent#925 (not on npm yet though)

[olalonde]

@bpdavenport this should fix my problem for now: #24 but ideally it would be better if bitgo didn't monkey patch superagent :)