Change TokenTracker.h m_remainingTokenCount from unsigned int to int or int64_t? about bitfunnel

[MikeHopcroft]

I think we should go with 64 bit as we are doing everywhere.

Sent from my Windows Phone

---

From: Dan Luumailto:[email protected]
Sent: ‎6/‎17/‎2016 4:51 PM
To: BitFunnel/BitFunnelmailto:[email protected]
Subject: [BitFunnel/BitFunnel] Change TokenTracker.h m_remainingTokenCount from unsigned int to int or int64_t? (#43)

Changing to a signed type would make checking for underflow more intuitive.

Changing to a 64-bit type would preclude the possibility of running into trouble because we have > 2B tokens outstanding. I don't think we know of any actual instances of that, but considering how few instances of the variable we have, I don't think we're really saving much memory by using a potentially 32 bit value.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/43, or mute the threadhttps://github.com/notifications/unsubscribe/AOpMZ7cbwTNVbE43RoW0aYSMOtn2QIL7ks5qMzL3gaJpZM4I40MT.