Comments (4)
@jarimatti I went ahead and added the evaluate
option and rewrote your wait_for
option based on a JS script. If you have time to test it out on your wait_for
use-case, that would be super nice 🙏
from chromic_pdf.
This looks nice! I agree, the wait_for
has known issues and this feels like a better and much more versatile approach. I will give this a spin.
from chromic_pdf.
If I'm the only one using wait_for
(and not even that much) I'm all in for removing it completely if you think it makes sense. I can easily replace any use of it with the new approach.
from chromic_pdf.
🤷♂️ idk if it has more users, @dgigafox perhaps... On the other hand the script ended up being so small that I think I'm fine with maintaining it in the code. At least this way it is tested (in contrast to when I would just use it as an example in the docs).
from chromic_pdf.
Related Issues (20)
- Timeouts on prod HOT 11
- Exception at startup on Gigalixir HOT 2
- Chromium on a different machine in the network HOT 9
- Ability to pass URL as the template source? HOT 1
- Ability to call `Emulation.setScriptExecutionDisabled` on a per-page basis? HOT 3
- Is it possible to use the service name instead of an ip address when use chrome_address? HOT 1
- Inspector.targetCrashed received when `no_sandbox: true` on Chromium 115 on Linux HOT 7
- Make checkout timeout configurable
- Changelog dates are wrong HOT 1
- websocket_debugger_url failing on windows erlang26/elixir15.7 HOT 2
- Footer is not displayed anymore with recent Chromiums HOT 23
- Troublesome PNG images? HOT 2
- Printing PDF crashes instantly before timeout HOT 13
- Loading external files fails when printing from in-memory HTML HOT 2
- Thoughts regarding executing ghostscript with stderr_to_stdout: true? HOT 8
- Will this work with msEdge and Google Chrome for Testing? HOT 5
- Remote Chrome print_to_pdf fails when using Templete HOT 3
- Define screen width when using `capture_screenshot/2` HOT 5
- Warning: You are using the legacy PDF interpreter HOT 3
- Question: Chromium "platform policies" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chromic_pdf.