Comments (4)
We've been throwing around similar ideas for a while, but it's low priority right now.
Pull Requests welcome, though!
I was thinking of making it more generic and making an npm package for each wordlist.
from bip39.
@dcousens I wonder if a lazy loading Proxy might be good...
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy
- When initializing BIP39, no wordlist is loaded.
- When any attribute of bip39.wordlists is accessed a getter Proxy takes the name of the thing being gotten and then attempts to
require('@bip39/' + name)
and return it. - If the parent app has
name
wordlist installed, require will find it and load it. - Maybe add hash values for each wordlist to check against known values.
That way, a person looking to add bip39 with English only to their app will do
npm install --save bip39 @bip39/english
Then in their app:
const bip39 = require('bip39')
// bip39 currently has not loaded any wordlists into memory
bip39.mnemonicToSeed(mn, pass)
// doesn't throw an error and still no wordlist in bip39.wordlists. since it doesn't use wordlists.
bip39.entropyToMnemonic(crypto.randomBytes(16))
// this will perform wordlist = wordlist || bip39.wordlists.english
// which will have the Proxy of wordlists do require('@bip39/english') and return that. storing it within bip39.wordlists
// if the require fails, return undefined.
hmmm... I'll have to test it out.
from bip39.
I don't think many packages is necessary. The only issue is the bundle burden, not npm.
from bip39.
I made a PR with one idea...
from bip39.
Related Issues (20)
- Duplicated word
- bip39 seems to be undefined in 3.+ versions HOT 1
- Why doesn't the address console HOT 1
- Recovery using only the first four letters of each word HOT 1
- Upgrade deps HOT 1
- Runtime errors HOT 1
- Function to convert entropy to seed? HOT 3
- Not work with rollup? HOT 1
- DevTools failed to load source map: Could not load content for file:///.../github/iancoleman/bip39/bootstrap.css.map: System error: net::ERR_FILE_NOT_FOUND HOT 1
- v3.0.4 is not working, v3.0.3 is fine HOT 2
- Invalid argument(s): Invalid mnemonic HOT 3
- ESM module support HOT 6
- Use more lightweight sha256 implementation HOT 6
- the testing is wrong!! HOT 1
- Electron + angular : how to unit test? HOT 3
- Serbian bip39 list HOT 1
- Error while using bip39.generateMnemonic(128) in react native HOT 3
- using bip39.generateMnemonic() is secure? HOT 1
- does it create a unused wallet everytime? HOT 1
- Bip39.ValidateMnemonic() always returns false in react HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bip39.