Restructure source so that individual functions can be imported w/o importing the entire source about bip39

[dcousens]

ES6 exports/imports, combined with tree shaking would make this irrelevant.

I think I'd sooner recommend that path then splitting up the source code unnecessarily when it nearly fits on 1 page.

[dcousens]

FWIW, I think it is nice to have each function isolated in the source anyway purely for organizational purposes but that is just me trying to be convincing that this change is worth merging smile

In an ideal world, everything might be a module. But in an ideal world, we might not even need to write code! Alas, I think breaking this file into mini-files of 10 lines hurts maintenance for something so small, therefore, NACK for that change alone.

[dcousens]

I don't hate the change, but, honestly the source is 159 lines.
What are you really trying to achieve here?

edit:

My specific concern here is the unorm dependency, which is quite large and not required for all of these utility functions.

Nevermind, OK, that is the goal.

[dcousens]

@bent0b0x the only function that is exposed presently that could take advantage of this, is entropyToMnemonic...

[bent0b0x]

the only function that is exposed presently that could take advantage of this, is entropyToMnemonic

yes and in turn generateMnemonic also benefits from this.

Also it seems like most of the word lists are required by any of the exposed functions. These files are relatively large, so not being required to import all of them just to use one function would be a nice win as well.

FWIW, I think it is nice to have each function isolated in the source anyway purely for organizational purposes but that is just me trying to be convincing that this change is worth merging 😄

[dcousens]

Also it seems like most of the word lists are required by any of the exposed functions. These files are relatively large, so not being required to import all of them just to use one function would be a nice win as well.

This is addressed in #74

[bent0b0x]

That's great about version 3! Do you have an idea as to when it may be released?

Re: one file vs multiple files, I would argue that if someone had originally written this package w/ all functions in individual files I'm not sure anyone would have batted an eye. So migrating to that state to help consuming applications seems like an acceptable transition. Then again I do not maintain this package and I understand the resistance.