browser support? about bip39

[NullVoxPopuli]

I have safe-buffer, which looking at the index.js inside safe-buffer, "it" is trying to require buffer which isn't in my node_modules.

This also confirms that cjs is the correct transform. thanks.

[junderw]

@thatsbrandon This question is better asked on a webpack forum/issue.

I do remember faintly that latest webpack requires some extra configuration to include Buffer.

[Red3nzo]

@junderw Thank you! I ended up looking into this extra configuration for Buffer in webpack & I found the solution which was to create my own resolve.fallback polyfill. I got my extension to compile a run without an issue

[dcousens]

@NullVoxPopuli what issues are you experiencing specifically?
This project does work if you use browserify or web-pack or the like.

[NullVoxPopuli]

I'm actually trying not to use browserify (feels hacky), webpack (personal vendetta), and am using rollup and broccoli.

if I just try to load the module directly: node_modules/bip39/index.js I get this error when my app boots (breaking all the things / not even rendering a page):

Could not find module `safe-buffer` imported from `(require)`

(same error happens when I try an amd transform on it)

if I do a common-js transform on it, my app loads, and then I get this error when I import the module:

Error: Could not find module `buffer` imported from `bip39`
TypeError: Cannot read property 'exports' of undefined

I have a unit test that file that only has:

import * as bip from 'bip39';
console.log(bip);

[dcousens]

@NullVoxPopuli this isn't an issue of this module.

We have safe-buffer listed as a dependency in our package.json:

bip39/package.json

Line 30 in bafbcd3

"safe-buffer": "^5.0.1",

The tools are what you need to fix 👍

[dcousens]

@NullVoxPopuli you'll need to add Buffer to your bundling setup.

OOI, why do you think browserify is "hacky"?

[Red3nzo]

@dcousens Do you have any links as to where I can add Buffer to my webpack build, I'm, new to webpack?

[NullVoxPopuli]

@dcousens the problem is that browserify "does what it needs to" to make "the build work" giving no cares for bundle size. polyfill node builtins bloats the output JS a ton.

Here is a < 100 line version of bip39(ish), using native browser APIs: https://github.com/NullVoxPopuli/emberclear/blob/31c2807ade0f09da1ace435b0a90267c3b2bddd3/client/web/addons/crypto/addon/workers/crypto/utils/mnemonic.ts

(ish) = I haven't tested against bip39, and don't need to for that specific app