Comments (4)
Interesting, but, this actually isn't our fault!
let buffer = Buffer.from('ea9d80e70b08bbfb6b7f2bca56c88ddb2c2d003e675a855779d81e11f3009346a', 'hex')
// <Buffer ea 9d 80 e7 0b 08 bb fb 6b 7f 2b ca 56 c8 8d db 2c 2d 00 3e 67 5a 85 57 79 d8 1e 11 f3 00 93 46>
You passed a 65-byte hex string, and a 32-byte Buffer is parsed.
Why does Node not throw? Ask them, but, alas.
from bip39.
Keeping open for now, as I'd like to hear your opinion, this is certainly a confusing (and unfortunate) result.
from bip39.
Looking back through my console I see the issue. TLDR adding the a
on the end was a typo in my test suite.
Both the 64 and 65 char entropy strings produce the same mnemonic
let a = bip39.entropyToMnemonic('ea9d80e70b08bbfb6b7f2bca56c88ddb2c2d003e675a855779d81e11f3009346')
// 'tunnel ugly degree bid merry world pupil tornado ski rent casino rent security length wet twice luxury rookie invite destroy busy leopard escape shoe'
let b = bip39.entropyToMnemonic('ea9d80e70b08bbfb6b7f2bca56c88ddb2c2d003e675a855779d81e11f3009346a')
// 'tunnel ugly degree bid merry world pupil tornado ski rent casino rent security length wet twice luxury rookie invite destroy busy leopard escape shoe'
Node's Crypto.randomBytes
correctly returned a 64 character hex encoded string but when I manually copied the 64 char string to my fixtures JSON I added an a
due to my vim workflow.
So my entropyToMnemonic
tests passed but the mnemonicToEntropy
tests failed because my assertion was for the 65 character string.
Apologies for the false flag. Again, thanks for a great lib. 🎩
from bip39.
from bip39.
Related Issues (20)
- Duplicated word
- bip39 seems to be undefined in 3.+ versions HOT 1
- Why doesn't the address console HOT 1
- Recovery using only the first four letters of each word HOT 1
- Upgrade deps HOT 1
- Runtime errors HOT 1
- Function to convert entropy to seed? HOT 3
- Not work with rollup? HOT 1
- DevTools failed to load source map: Could not load content for file:///.../github/iancoleman/bip39/bootstrap.css.map: System error: net::ERR_FILE_NOT_FOUND HOT 1
- v3.0.4 is not working, v3.0.3 is fine HOT 2
- Invalid argument(s): Invalid mnemonic HOT 3
- ESM module support HOT 6
- Use more lightweight sha256 implementation HOT 6
- the testing is wrong!! HOT 1
- Electron + angular : how to unit test? HOT 3
- Serbian bip39 list HOT 1
- Error while using bip39.generateMnemonic(128) in react native HOT 3
- using bip39.generateMnemonic() is secure? HOT 1
- does it create a unused wallet everytime? HOT 1
- Bip39.ValidateMnemonic() always returns false in react HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bip39.