p2sh-p2wpkh && bech32 support for getkeypool about hwi

[achow101]

It seems that bip32utils has been taken down :/

[achow101]

I don't think this really matters since importing a pubkey imports all of the single key scripts for it, not just the one specified. This includes p2sh segwit and bech32 ones.

[instagibbs]

This is extremely Core behavior, but perhaps this lowers the immediate need for it.

[Sjors]

That had me confused for a while as well. In case someone does want to add it, this line would need to be changed: https://github.com/achow101/HWI/blob/master/hwilib/commands.py#L101

Unfortunately it seems bip32utils doesn't have bech32 support yet either.

[instagibbs]

@Sjors we could switch to libwally which supports this and has python bindings

[instagibbs]

/blockstreamshill

[Sjors]

It's also used by c-lightning, also one of those Blockstream conspiracies, but at least that means it's maintained :-)

[instagibbs]

Yes it is actively maintained and used in multiple products(including GreenAddress), which is nice.

[Sjors]

Better still would be to add support for output descriptors to importmulti (or a new command). That would also allow cleanly separating m/44' keys from m/49' and m/84' keys. That would keep the users BIP39 seed compatible with (at least some) other wallets.

Is getnewaddress smart enough to look for the right key type, and throw an error if the keypool for that type is empty? The GUI would also have to be made a bit smarter, e.g. dis- or enabling the bech32 checkbox, or communicate in some other way that the keypool needs replenishing.

[achow101]

I wanted to avoid integrating larger libraries like libwally because there's a lot of additional stuff that we don't need included there.

[Sjors]

This should be easier on top of bitcoin/bitcoin#14454 and bitcoin/bitcoin#14565

[achow101]

#47 Implements this.