Comments (12)
It seems that bip32utils has been taken down :/
from hwi.
I don't think this really matters since importing a pubkey imports all of the single key scripts for it, not just the one specified. This includes p2sh segwit and bech32 ones.
from hwi.
This is extremely Core behavior, but perhaps this lowers the immediate need for it.
from hwi.
That had me confused for a while as well. In case someone does want to add it, this line would need to be changed: https://github.com/achow101/HWI/blob/master/hwilib/commands.py#L101
Unfortunately it seems bip32utils doesn't have bech32 support yet either.
from hwi.
@Sjors we could switch to libwally which supports this and has python bindings
from hwi.
/blockstreamshill
from hwi.
It's also used by c-lightning, also one of those Blockstream conspiracies, but at least that means it's maintained :-)
from hwi.
Yes it is actively maintained and used in multiple products(including GreenAddress), which is nice.
from hwi.
Better still would be to add support for output descriptors to importmulti
(or a new command). That would also allow cleanly separating m/44' keys from m/49' and m/84' keys. That would keep the users BIP39 seed compatible with (at least some) other wallets.
Is getnewaddress
smart enough to look for the right key type, and throw an error if the keypool for that type is empty? The GUI would also have to be made a bit smarter, e.g. dis- or enabling the bech32 checkbox, or communicate in some other way that the keypool needs replenishing.
from hwi.
I wanted to avoid integrating larger libraries like libwally because there's a lot of additional stuff that we don't need included there.
from hwi.
This should be easier on top of bitcoin/bitcoin#14454 and bitcoin/bitcoin#14565
from hwi.
#47 Implements this.
from hwi.
Related Issues (20)
- dependency to typing_extensions HOT 1
- Signing multisig PSBTs on Trezor devices returns invalid signatures for Segwit script types HOT 3
- hwi could not detect Ledger Nano S Plus HOT 2
- Why does HWI 0.5.0 have a fixed once_cell dependency version 1.14? HOT 3
- Ledger Bitcoin App 2.1.1 sign psbt does not contribute a signature HOT 10
- bitbox02 should not be a hard dependency HOT 2
- hwi 2.2.1 seem doesn't work on mac M1 chip HOT 6
- cbor 1 is old, unmaintained, upstream repo is gone, incompatible with newer Python versions HOT 4
- Signing a P2WSH multisig input fails on updated Ledger firmware & Bitcoin app HOT 7
- [rfc] Require emulator/simulator for device support
- Base58 decode_check always returns invalid checksum HOT 2
- Ledger: Unable to sign non-standard derivation paths
- Support displaying Taproot addresses on Coldcard Edge (6+) firmware
- Bitbox fails to sign PSBT HOT 6
- ci bug HOT 1
- Support Trezor Safe 3 HOT 6
- Documentation: Typo?
- Trezor T can't sign >100 inputs HOT 12
- [Feature Request] Add ability to pass cli arguments with stdin HOT 3
- Windows thinks hwi.exe is a trojan HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hwi.