display fees in Sat / vByte instead of (μ/m)BTC/kB about gui

[hebasto]

hmm it looks like it might be awhile until that experimental fork is merged?

That's true.

might be good to still do this in the meantime.

A PR is always welcome.

Yes sat/vbyte makes sense. Even I was planning to create an issue or submit PR related to same thing. Most of the tools use sat/vbyte. If a newbie tries bitcoin core wallet, he will have to Google conversion of sat/kilobyte to sat/byte and also understand the difference between byte and vbyte.

[Sjors]

Using "sat/byte" instead of "sat/vbyte" is fine; we make that shortcut in other places. As of bitcoin/bitcoin#11413 the RPC supports this too.

I can make a PR is people think this is a good idea.

I no longer plan to do this myself :-)

[jonatack]

The results of these informal twitter polls yesterday seem heavily in favor of sat/vB.

https://twitter.com/jonatack/status/1318890833131823104

[Sjors]

That's good to hear. I would still drop the v though.

[jonatack]

Standardizing on a unit is a proposed meeting topic at today's wallet meeting: sat/B, sat/vB, sat/kvB, etc. :)

[michaelfolkson]

I don't agree with getting rid of the v in vbyte. Non-technical people will just ignore the v (no downside for them) but it gives technical people a stepping stone to understanding what fee they are setting. If it is just byte there will need to be docs saying "when we said byte we actually meant vbyte". Not ideal

[Sjors]

We currently don't use vbyte anywhere in the RPC or GUI. Switching to that is orthogonal to adding satoshi support (and it's been tried in before: bitcoin/bitcoin#12180).

[andrasfuchs]

I think it's a good idea, I would love to see this implemented.
@fanquake , would you still be open to work on this PR?

[jonatack]

Moving to sat/vB is now starting to happen in the RPC, so 👍 on doing it in the GUI.

[viaj3ro]

I'd also love to see this implemented in the GUI. Preferably s/vb. The respective fee should also be shown for incoming and outgoing transactions and not just when creating a new transaction (as described in #255)

[jb55]

needed this today... anyone working on this or should I take a stab?

[jonatack]

@hebasto is gui dev still taking place here or has it moved to the qemu repo? This repo seems fairly quiet.

[hebasto]

@hebasto is gui dev still taking place here or has it moved to the qemu repo?

QML-based GUI repo indeed combines efforts of designers and developers.

This repo seems fairly quiet.

There are always a plenty of PRs to review and issues to fix...

[jb55]

On Mon, Oct 10, 2022 at 06:06:44AM -0700, Hennadii Stepanov wrote: > @hebasto is gui dev still taking place here or has it moved to the qemu repo? QML-based GUI [repo](https://github.com/bitcoin-core/gui-qml) indeed combines efforts of [designers](https://bitcoincore.app/) and developers.

TIL, I'll check this out

[jb55]

hmm it looks like it might be awhile until that experimental fork is merged? might be good to still do this in the meantime.

[Sjors]

Moving to sat/vB is now starting to happen in the RPC, so 👍 on doing it in the GUI.

It even landed in the RPC (one or two major releases ago), so this change shouldn't be too controversial for the GUI at this point.

The installation "wizard" could even set the default to sat/byte for new users.