Tor status indicator icon in bottom right about gui

[Sjors]

It might make sense to show no icon at all if there's no Tor connection.

When we do show an icon, I suggest only showing that when the connection is actually secure:

1. all outbound connections go through Tor; and
2. inbound connections are disabled, or are through Tor

In particular, there's not much privacy benefit in connecting to some nodes via Tor and some nodes via plain internet.

This approach makes the "connecting" icon unnecessary, because we already have an indicator for connectivity in general.

[jonatack]

Concept ACK

[jonatack]

Nice!

[michaelfolkson]

I like the minimalism, I think that is important for Core. The "Not connected" icon and "connected" icons are clear. Maybe the "connecting" icon could be fainter. Similar to the "Not connected icon" but without the cross.

[maflcko]

Why not pick the icons that look good even when scaled down (non high-DPI displays)?

Tor made an effort and recently changed those: https://trac.torproject.org/projects/tor/ticket/25702

[Bosch-0]

Why not pick the icons that look good even when scaled down (non high-DPI displays)?

SVG will look fine when scaled down or up

[maflcko]

When rendering an SVG, there will always be a limit until it can no longer be scaled down and still be distinguished from a blurry blob. Generally, the less detail an SVG has, the less pixels are needed to still represent the details.

[Bosch-0]

I'll look at what Tor has done, can always have different icon sizes in the repo - the ones I uploaded in my PR are 128 x 128 same as the other icons use in the bottom menu.

[hebasto]

Should we distinguish "node has a Tor network connection" and "node has only Tor network connection"?
The former could lead an unexperienced user to a false sense of privacy.

Also "listening to Tor" (inbound connections) and "connecting to Tor" (outbound connections) are controlled by different options, and it means there are 4 different states of the node. I think Tor icons should cope them all, no?

[Bosch-0]

New designs using only one icon based on feedback. If the icon is clicked the user should be re-directed to the 'Network' tab in settings -> options.

Tor tooltip.

If the user is connecting through a Tor proxy (and not a IPv4 or IPv4 one) should the proxy 'P' icon in the bottom right be shown still? Based on my understanding I think not but am not sure if they have separate technical reasons for showing both.

Figma source files for icon
Figma source files for designs

[hebasto]

@Bosch-0 @Sjors Please review bitcoin/bitcoin#19926

[hebasto]

@Bosch-0 @Sjors Please review bitcoin/bitcoin#19926

The PR has been moved into this repo: #86.