Comments (14)
More emphasis on the primary action makes sense. I think there's a QT standard way of marking buttons as such:
from gui.
@Sjors
Unfortunately, on Linux it looks not such emphasized:
from gui.
I see a subtle blue line around Hide. Can you show a screen with more than 1 button? Doing non-native styling can get real ugly real fast in my experience.
from gui.
I see a subtle blue line around Hide. Can you show a screen with more than 1 button?
Doing non-native styling can get real ugly real fast in my experience.
Agree.
from gui.
I think these are both clear enough, the static build (which we ship) is the most clear.
So in the original example, maybe we just need to mark the Receive button as primary?
from gui.
I think these are both clear enough, the static build (which we ship) is the most clear.
So in the original example, maybe we just need to mark the Receive button as primary?
Actually, in a such way not the "primary action" button highlighted rather the focused one.
from gui.
@statusquont
Mind providing an example among desktop widget-based applications to find the solution without non-native styling?
from gui.
I'm not sure if I understand what you're asking for, but hopefully this helps, from the GitHub Desktop application (Windows).
If I misunderstood the question please advise.
from gui.
Concept ACK.
To implement this feature into the code (say, "primary push button") some design decisions are required to make it harmonized with the used styles on all supported platforms.
It could be made as artworks, e.g., https://doc.qt.io/qt-5/gallery.html
Doing non-native styling can get real ugly real fast in my experience.
That is it what we should avoid for sure.
from gui.
Yeah, that makes a lot of sense. IMO a good design should be there to help a user make decisions, but other than that, get out of the way and don't cause distraction.
I'm not too familiar with QT, but I would presume (and hope) that efforts have been made in that project to consider usability for all types of users (including vision impaired for example) and design the UI accordingly. So leaning on QT's prior work makes a lot of sense. In that regard, I'll retract my previous suggestion of "give primary action buttons an orange background" since that seems to be outside of the scope at this time. Perhaps it can be revisited at a later time as the Bitcoin Design working group make further progress to establish a set of visual standards.
To wrap this issue up, I'd just ask whether or not the 'Create New Receiving Address' button is inheriting the default button push properties from QT in order to help the user make a decision?
https://doc.qt.io/qt-5/qpushbutton.html#default-prop
I'm not sure where/how to check the code to answer this question myself.
from gui.
To wrap this issue up, I'd just ask whether or not the 'Create New Receiving Address' button is inheriting the default button push properties from QT in order to help the user make a decision?
https://doc.qt.io/qt-5/qpushbutton.html#default-propI'm not sure where/how to check the code to answer this question myself.
Mind testing #39 ?
from gui.
Looks improved, slightly, but still an improvement nonetheless! 👍
from gui.
Not sure of proper protocol here. Do I close this issue? Or does it auto-close once #39 gets closed?
from gui.
Not sure of proper protocol here. Do I close this issue? Or does it auto-close once #39 gets closed?
The latter one :)
from gui.
Related Issues (20)
- Testnet/mainnet cross-reading of settings
- commit ecb617fefe drops qt/gui support on MacOS 10.15.7 HOT 5
- About logo icon doesn't denote chain type (?) in About/ Help message window/ dialog HOT 2
- Remove BDB checkbox in wallet creation dialog HOT 6
- High CPU load when network traffic page left open HOT 7
- `used` balance should be shown on overview page HOT 1
- When using an unencrypted read-only wallet, pressing "Create Unsigned", shows "This operation needs you wallet passphrase to unlock the wallet" HOT 2
- Send: ability to (re)view automatically selected coins
- macOS qt QTimer::stop crash on v26.0rc2
- The logo icon doesn't show properly under Wayland HOT 2
- Weird focus rect displayed on inital sync HOT 4
- "Open bitcoin URI" dialog could give more feedback on what's wrong with BIP21 URI
- New crash in v26.0 HOT 7
- How to get started with Contribution HOT 5
- I don't think we should add a lock icon or something like that; there are significant benefits of having encrypted connections on a large scale, but users in general shouldn't assume that their specific connections are more secure for their specific purposes when they're v2.
- ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in HOT 5
- When selecting a custom data directory on first launch of Bitcoin Core GUI on Mac, where is that setting stored? HOT 4
- test: `migrateSettings` fails on Windows HOT 1
- Segfault in qt/clientmodel.cpp:92 on every shutdown HOT 5
- Bitcoin core UI is unresponsive while syncing HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gui.