Give primary action items more visual weight about gui

[Sjors]

More emphasis on the primary action makes sense. I think there's a QT standard way of marking buttons as such:

[hebasto]

@Sjors
Unfortunately, on Linux it looks not such emphasized:

[Sjors]

I see a subtle blue line around Hide. Can you show a screen with more than 1 button? Doing non-native styling can get real ugly real fast in my experience.

[hebasto]

@Sjors

I see a subtle blue line around Hide. Can you show a screen with more than 1 button?

Qt 5.9.8 (static):

Qt 5.12.8 (dynamic):

Doing non-native styling can get real ugly real fast in my experience.

Agree.

[Sjors]

I think these are both clear enough, the static build (which we ship) is the most clear.

So in the original example, maybe we just need to mark the Receive button as primary?

[hebasto]

I think these are both clear enough, the static build (which we ship) is the most clear.

So in the original example, maybe we just need to mark the Receive button as primary?

Actually, in a such way not the "primary action" button highlighted rather the focused one.

[hebasto]

@statusquont
Mind providing an example among desktop widget-based applications to find the solution without non-native styling?

[statusquont]

I'm not sure if I understand what you're asking for, but hopefully this helps, from the GitHub Desktop application (Windows).

If I misunderstood the question please advise.

[hebasto]

Concept ACK.

To implement this feature into the code (say, "primary push button") some design decisions are required to make it harmonized with the used styles on all supported platforms.

It could be made as artworks, e.g., https://doc.qt.io/qt-5/gallery.html

Doing non-native styling can get real ugly real fast in my experience.

That is it what we should avoid for sure.

[statusquont]

Yeah, that makes a lot of sense. IMO a good design should be there to help a user make decisions, but other than that, get out of the way and don't cause distraction.

I'm not too familiar with QT, but I would presume (and hope) that efforts have been made in that project to consider usability for all types of users (including vision impaired for example) and design the UI accordingly. So leaning on QT's prior work makes a lot of sense. In that regard, I'll retract my previous suggestion of "give primary action buttons an orange background" since that seems to be outside of the scope at this time. Perhaps it can be revisited at a later time as the Bitcoin Design working group make further progress to establish a set of visual standards.

To wrap this issue up, I'd just ask whether or not the 'Create New Receiving Address' button is inheriting the default button push properties from QT in order to help the user make a decision?
https://doc.qt.io/qt-5/qpushbutton.html#default-prop

I'm not sure where/how to check the code to answer this question myself.

[hebasto]

@statusquont

To wrap this issue up, I'd just ask whether or not the 'Create New Receiving Address' button is inheriting the default button push properties from QT in order to help the user make a decision?
https://doc.qt.io/qt-5/qpushbutton.html#default-prop

I'm not sure where/how to check the code to answer this question myself.

Mind testing #39 ?

[statusquont]

Looks improved, slightly, but still an improvement nonetheless! 👍

[statusquont]

Not sure of proper protocol here. Do I close this issue? Or does it auto-close once #39 gets closed?

[hebasto]

Not sure of proper protocol here. Do I close this issue? Or does it auto-close once #39 gets closed?

The latter one :)