Respect the users terminal color-set about cordless

[linuxthefish]

please stop emailing me about your IRC client

[Bios-Marcel]

Just learn to use GitHub, not my fault, lol.

Just hit the "Unsubscribe" Button on the issue page.

[Bios-Marcel]

So, I can't actually choose the colors themselves, those are defined by the terminal. I have started limiting myself to using the first 16 colors though. That's all I can do! As for everything else, I could make the colors used customizable, a color theme feature if you will.

[linuxthefish]

UNSUBSCRIBE

[Bios-Marcel]

So, I did the lazy version now @avahe-kellenberger

The default theme now uses the default colors and you can create your own theme. However, the format is shitty, as it uses integers. There is a file at tools/theme/theme.go where you can change the values and receive the theme code. It's not straightforward, but it works. There is room for improvement :D

[linuxthefish]

abbestellen

[linuxthefish]

Unsubscribe me please

[linuxthefish]

Thank you

[avahe-kellenberger]

Sure thing, I'll start playing around with it this weekend.

[linuxthefish]

Duplicate of #8

[NobleDraconian]

a color theme feature if you will.

I would definitely love it if we could load predefined themes (and even user defined ones!). I'm running a custom theme on my linux installation (eDEX UI to be exact), so having cordless respect the terminal colors would make it fit right in with my theme.

[BoxWithAHat]

I agree. If you want high contrast, it seems to be high contrast when used in TTY, although the "message edit mode" has a yellow background that makes it near impossible to see what you're editing.

[Bios-Marcel]

Yeah, the yellow sucks ^^

I'll improve some things soon. PRs are welcome as well, as I don't have much time this week, due to exams n' such.

[Bios-Marcel]

The yellow background during edit mode has now been replaced with a yellow border, that's much better 👍

[avahe-kellenberger]

What is determining the color of the application? I'm considering looking into fixing the issue if the other developer(s) don't have the time or will. I really like the application but the colors are killing my eyes

[Bios-Marcel]

Hey @avahe-kellenberger

So, as far as I understand it, there are at least 16 colors, those should be available across all systems. Meaning that if you limit yourself to using only those colors, a terminal can decide on a theme by "redefining" those colors. I have hardcoded some colors that lie out of this space, those hardcoded colors have to be removed, by default there should be no more than the 16 colors that are available everywhere.

I think it'd be good if users would have a choice to apply a theme, I actually started working on this already but haven't really done too much yet, I can push it to a branch if you want to.

Themes could for now just be a json file with all the properties, take a look at https://github.com/Bios-Marcel/cordless/blob/master/app/app_nonwindows.go. Those are the properties that are currently important, I'll probably have to add more later, but it'd be good to have the base for now.

What I did was wrapping the tview.Theme in a new struct (lets call it cordless.Theme) that allows adding more properties later on. Just take a look at the branch: https://github.com/Bios-Marcel/cordless/tree/theme_wip

[Bios-Marcel]

@avahe-kellenberger btw if you don't intend to work on this, it'd be nice to tell me, because I stopped working on this for now, since I wanna avoid doing something that someone else will do :D

[avahe-kellenberger]

Thanks for the information - I took this as you were still working on it, my apologies. I can look into it if you aren't going to implement the feature anytime soon. I'm working on a few side projects at the moment so it would probably be a week or two until I could get to it.

[Bios-Marcel]

@avahe-kellenberger I'd be happy if you were to do it :)

[avahe-kellenberger]

@Bios-Marcel It's not a full "create your own theme" solution, but simply making defineColorTheme an empty function seems to achieve what I wanted.

My terminal window background stays its normal color and the colored nicknames etc don't interfere with my theme. I think making this change could be a decent start to fully implementing predefined user themes.

My theme without this change

My theme with this change

[Bios-Marcel]

For me it does the opposite, it breaks everything :|

Maybe I am missunderstanding something.

[Bios-Marcel]

So, I actually specified the colors hardcoded, because either tcell or tview did something and it broke my default colors. So I was annoyed and this was somewhat a workaround.

[avahe-kellenberger]

Are there builtin defaults for tcell or tview then? Or could you give a synopsis of what happens on your system (your terminal emulator, difference in colors between cordless and your terminal colors, etc)?

[Bios-Marcel]

So, I have updated all packages some day and suddenly it stopped using my colors, I didn't change anything on my system. I could however see if it still works on my second system.

EDIT I meant Go packages (cordless dependencies)

EDIT 2 At that point, I didn't use go modules I think

[avahe-kellenberger]

I didn't do anything other than clone the theme_wip branch, change defineColorTheme to be an empty function and then compile. Tried in a couple different terminals on arch linux (VTE based and st (simple terminal)) and it seems to respect my terminal's color theme. What OS and terminal are you using?

[Bios-Marcel]

Ubuntu, termite (vte based)

[Bios-Marcel]

Here, little comparison. The right side is correct:

[avahe-kellenberger]

It seems to be only an issue with termite - I tried a few more terminals and termite is the only one with this issue.

[Bios-Marcel]

@avahe-kellenberger In hindsight ... it was quite stupid for me not to test this. Fuck termite I guess

[avahe-kellenberger]

Haha it happens. Perhaps we could close this and open an issue specifically for user-defined themes?

[Bios-Marcel]

I guess that sounds like a good plan. I'll just delete the hardcoded theme stuff then ^^

[Jarvvski]

@Bios-Marcel what are the formats? Just integers, but from what? The RGB values concatenated together?

[Bios-Marcel]

yeah