💅 Biome throw useExhaustiveDependencies error when useRef type is defined using type assertion about biome

[XiNiHa]

I'm not sure how many edge cases we should handle. Currently having these in mind:

• TS as operator (useRef(foo) as MutableRefObject<Foo>) (eslint-plugin-react-hooks only handles this)
• TS satisfies operator (useRef(foo) satisfies MutableRefObject<Foo>)
• TS non-null assertion operator (useRef(foo)!)

There are many other kind of edge cases, like....

• Array destructure (const [a, b] = [useRef('a'), useRef('b')])
• Comma operator (const a = (console.log('a'), useRef('a')))
• IIFE (const a = (() => useRef('a'))(), can be much more complex)
• let reassignment (let a = useRef('a'); a = Math.random())
• ...

It's somewhat obvious that it is unrealistic to handle all of those edge cases. Therefore I believe we should scope which edge cases to handle. Personally, I think all of TS operator cases and array destructure should be handled, while other cases are too specific/niche to work on.

[XiNiHa]

I guess it's an edge case that was not handled correctly from #996. I'll look into it after fixing #1637.

[ematipico]

I think so too. We should strive to cover the most used patterns and call it a day.

We should take this opportunity and update the documentation explaining the expectations of this rule

[Sec-ant]

Speaking of IIFE, there're also cases where one can use IIFE to return a function that can be used in useCallback or useEffect. This is a common functional pattern in JS to hoist and memoize static variables. The useExhaustiveDependencies rule doesn't catch it currently. It would be great to handle this kind of edge cases.

https://biomejs.dev/playground/?code=aQBtAHAAbwByAHQAIAB7ACAAdQBzAGUARQBmAGYAZQBjAHQALAAgAHUAcwBlAFMAdABhAHQAZQAgAH0AIABmAHIAbwBtACAAIgByAGUAYQBjAHQAIgA7AAoACgBlAHgAcABvAHIAdAAgAGYAdQBuAGMAdABpAG8AbgAgAEYAKAApACAAewAKAAoAIAAgAGMAbwBuAHMAdAAgAFsAYQAsACAAcwBlAHQAQQBdACAAPQAgAHUAcwBlAFMAdABhAHQAZQAoADEAKQA7AAoAIAAgAAoAIAAgAHUAcwBlAEUAZgBmAGUAYwB0ACgAKAApACAAPQA%2BACAAYwBvAG4AcwBvAGwAZQAuAGwAbwBnACgAYQApACwAIABbAF0AKQA7AAoACgAgACAAdQBzAGUARQBmAGYAZQBjAHQAKAAoACgAKQAgAD0APgAgACgAKQAgAD0APgAgAGMAbwBuAHMAbwBsAGUALgBsAG8AZwAoAGEAKQApACgAKQAsACAAWwBdACkAOwAKAH0A