Coder Social home page Coder Social logo

Comments (15)

somerandow avatar somerandow commented on July 23, 2024 1

Took a stab at this, as I actually just ran into the same issue, albeit on plain Docker. While bazarr doesn't necessarily have the same issue with linking, figured all the 'arr apps should all probably be laid out the same.
If the commits here look good/cohesive, I can go ahead and do the same for sonarr, etc. and toss a PR together for each.

from billimek-charts.

billimek avatar billimek commented on July 23, 2024

Hi @abel408, correct! We have the extraExistingClaimMounts configuration option to help address this (also for radarr)

An example of the implementation is here:

    persistence:
      config:
        enabled: true
        storageClass: "rook-ceph-block"
        size: 2Gi
      downloads:
        enabled: false
      tv:
        enabled: false
      extraExistingClaimMounts:
        - name: media
          existingClaim: nfs-media-pvc
          mountPath: /media
          readOnly: false

It seems like we should still 'allow' someone to choose to have the different mounts for downloads and tv/movies. What do you think?

from billimek-charts.

abel408 avatar abel408 commented on July 23, 2024

Ahhh, thank you. I do agree with allowing different mount points, however, the chart by default will create a mount point for each and radarr and sonarr, by default, will use hardlinks so I think there is a bit of a discrepancy there. I would imagine the only reason someone would want a mount point for each would be if they are organizing things manually? I just learned the hard way that radarr and sonarr have been duplicating all my files and am now in the process of reorganizing :/. I have a feeling I'm not the only one.

from billimek-charts.

billimek avatar billimek commented on July 23, 2024

@abel408 this is a good point, we should consider changing the default behavior. Something different than the extraExistingClaimMounts would be necessary for the two charts because we won't have an existing claim to reference by default.

@onedr0p what do you think? I think we would need to change the chart to collapse /downloads and /tv or /movies into a single PVC and allow folks to leverage extraExistingClaimMounts if they really want them separate. We could bump the chart major version to indicate a breaking change.

from billimek-charts.

onedr0p avatar onedr0p commented on July 23, 2024

@billimek do you think a single media volume is good instead of downloads and tv or movies ?

from billimek-charts.

billimek avatar billimek commented on July 23, 2024

@onedr0p yeah, exactly! Can you think of any downsides taking that approach?

from billimek-charts.

onedr0p avatar onedr0p commented on July 23, 2024

@billimek maybe, my current deployments use media in extraExistingClaimMounts. Do you think that is a conflict?

    persistence:
      downloads:
        enabled: false
      tv:
        enabled: false
      extraExistingClaimMounts:
        - name: media
          existingClaim: nfs-media-pvc
          mountPath: /media
          readOnly: false

from billimek-charts.

billimek avatar billimek commented on July 23, 2024

With the change we're discussing, yeah. I see it as being something like this:

    persistence:
      config:
        enabled: true
      media:
        enabled: true
        existingClaim: nfs-media-pvc
        subPath: /media
      extraExistingClaimMounts: <not needed now>

... which would be a 'breaking' change

from billimek-charts.

onedr0p avatar onedr0p commented on July 23, 2024

Sounds good! I think this would be a great change.

from billimek-charts.

onedr0p avatar onedr0p commented on July 23, 2024

@WojoInc looks great, feel free to open PRs :)

from billimek-charts.

somerandow avatar somerandow commented on July 23, 2024

Sg! Submitted PR for Bazarr. I plan on doing the same for Sonarr, Radarr, and Lidarr after work today. Any other charts that may need the same thing done?

from billimek-charts.

billimek avatar billimek commented on July 23, 2024

Should be fixed now by #224, #225, #226, & #227

from billimek-charts.

windowsrefund avatar windowsrefund commented on July 23, 2024

As someone who is starting out with these charts, I'm not worried about backwards compatibility or breaking changes and just want to get things up and running as cleanly as possible. Is there some documentation or walk-through published anywhere that would show how to create a sane values.yaml (to be passed into the install via -f) which results in sonarr using the same volume for radarr and plex? In other words, all 3 would end up using the same PVC for media reads and writes?

from billimek-charts.

onedr0p avatar onedr0p commented on July 23, 2024

@windowsrefund what you want is NFS storage but radarr and Sonarr don't support it, it's better to use block storage

from billimek-charts.

windowsrefund avatar windowsrefund commented on July 23, 2024

Hi, I'm actually using openebs block storage (cStor) but think I can get RWX if I plug nfs-server-provisioner into the mix. Baically, this

I should just be able to create a PVC on my own for the purpose of using from sonarr, radarr, and the rest.

from billimek-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.