Coder Social home page Coder Social logo

Comments (7)

bilelmoussaoui avatar bilelmoussaoui commented on August 29, 2024

Yes that's expected because the handle is unexported when the WindowIdentifier is dropped.

I wonder what would be the best way forward here, but addikg a comment at least seems fine to me

from ashpd.

Cogitri avatar Cogitri commented on August 29, 2024

Alright, I’ll submit a PR later today.

Another question: To work around this I currently just hold onto the WindowIndentifier in a OnceCell that’s initialised when the window is created. Is that fine or should I always re-request the WindowIdentifier?

from ashpd.

bilelmoussaoui avatar bilelmoussaoui commented on August 29, 2024

I would say you can keep only once instance around by wrapping it in a OnceCell. I don't know if we can do something about it on the crate side?

from ashpd.

Cogitri avatar Cogitri commented on August 29, 2024

Hm, I don’t really think we can other than hacky ways like having a global HashMap<WeakRef, WindowIdentifier> to remember the WindowIdentifier

from ashpd.

bilelmoussaoui avatar bilelmoussaoui commented on August 29, 2024

Ah yeah indeed. That would be very painful to do. I guess going with a comment would be good enough for now.

Feel free to open another issue regarding the usage of the Default implementation of WindowIdentifier in some of the portals

from ashpd.

A6GibKm avatar A6GibKm commented on August 29, 2024

Cant we do a static Once that holds the identifier?

from ashpd.

bilelmoussaoui avatar bilelmoussaoui commented on August 29, 2024

You can, from the application side

from ashpd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.