Comments (8)
Got it.
So you are using a strategy that sometimes your package is being published with a version that is already up there, that is ok to you and you just want to ignore the error.
This makes sense, otherwise, you will have to implement a validation to avoid publishing a version that is already there and make it viable in a mono-repo environment. Also, modify the CI to do not launch an error because that is the expected result.
That is the spirit of this executor/builder to automate repeatable things related to package publishing.
Thank you so much, good first issue.
from ngx-deploy-npm.
A quick note about the original feature request, I think the ability to call ngx-deploy-npm:deploy right after @jscutlery/semver:version succeed, would fix the "package already published" error more reliably than adding an option to ignore NPM errors.
I agree that jscutlery/semver#167 would be better than implement a new option to ignore errors. We are having already a discussion (#73) to integrate both tools.
When we consider that both tools are holding hands I'm going to close this issue.
from ngx-deploy-npm.
The implementation of Semver has been tested successfully.
Please use the post-targets
Semver's feature
--
A configuration example will be soon on the readme.
In the meantime, you can find an example configuration on the discussion #73. Another example is in our workspace
from ngx-deploy-npm.
Hello Gentlemens 🎩
I love the discussion generated here. You are bringing several good and exciting points, it's difficult to keep track of this here (on an issue), so, I created the discussion #73 to group all subjects/issues regarding the integration with Semver.
I going to migrate the points mentioned here to talk about them in their own space.
If you have another, it's more than welcome.
from ngx-deploy-npm.
@edbzn seems like your plugin and ours are natural allies. I'm seriously considering referencing yours in the Version Bumping Readme section.
It's not the first time that this tool has something to do with Semver, take a look at this -> #66
from ngx-deploy-npm.
Hi there,
We are planning to include support of package publishing in @jscutlery/semver v3. We want to provide a fully automated release cycle in the CI (releasing + publishing), the idea is to add the ability to call another builder/executor whenever semver succeeds to bump a package, in our case ngx-deploy-npm:deploy.
The related issue is here jscutlery/semver#167, note that I already started working on it. I would love to get your feedback guys.
I can already see conflicting things between ngx-deploy-npm and @jscutlery/semver, this option --package-version for example can conflict/override what semver did just before.
I think we would need to work together @dianjuar to make both executors compatible and reliable, what do you think?
from ngx-deploy-npm.
A quick note about the original feature request, I think the ability to call ngx-deploy-npm:deploy right after @jscutlery/semver:version succeed, would fix the "package already published" error more reliably than adding an option to ignore NPM errors.
from ngx-deploy-npm.
This is definitely an interesting problem that I'm not sure has an existing architectural pattern within Nx/Angular tasks, @edbzn task essentially creates a different affected graph which should be communicated over to the publish task. We could create a post/pre action as a configuration to either one of your plugins but I feel like that may be an anti-pattern?
both your plugins are amazing for what they do, and version bumping/publishing are pretty well delineated. What i'm saying is, I'd like to make sure these libraries focus on doing one thing really well. Who know what sort of storage I'd actually like to send my package to (github releases?) and who knows what sort of semantic versioning strategy I'd like to implement.
from ngx-deploy-npm.
Related Issues (20)
- Open version range on dependencies for the published package HOT 9
- TypeError: Cannot read properties of undefined (reading 'defaultProject') HOT 10
- Fix `Tests @next version nrwl and angular` workflow HOT 3
- e2e test for Nx@14 HOT 2
- Error: context.projectGraph is undefined HOT 4
- Setting registry not being reflected from nx executor options HOT 6
- Upgrade to Nx 16, or open version range HOT 3
- Parametrize Nx npm scope on the script `create-nx-workspace` HOT 1
- Remove integration test from the main workflow and put it scheduled
- Fail dry run deploy if version already exists in the registry HOT 4
- Support for packages that doesnt require building HOT 14
- Could not resolve peer dependency [email protected] HOT 5
- Github Actions example HOT 6
- Deploy script fails for packages that depend on other packages HOT 8
- buildTarget is hardcoded and only modifies configuration HOT 5
- Upgrade @nx to ^17.0.0 HOT 1
- Update `README_contributors.md`
- [Question]: What's the alternative for `noBuild`? HOT 3
- Add support for Nx v19 HOT 2
- Remove `overrides` from `package.json`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-deploy-npm.