Coder Social home page Coder Social logo

Comments (4)

benpate avatar benpate commented on May 26, 2024

@1cg -- This SSE code works but it's not ready to submit, yet.

I found an error reconnecting after I restart my SSE server (which is supposed to happen automatically). I'm working through a manual reconnect now, and will include that as an update to htmx, too, if necessary.

from _hyperscript.

benpate avatar benpate commented on May 26, 2024

I've made some updates to this that are (nearly) ready for testing. I want to add public connect() and close() methods to the variable that's published into the hyperscript scope, and then I think this will be ready to go.

@1cg -- There's one experimental change that I wanted to get your eyes on before I move forward:

I'm using JSDoc-formatted comments in most of the new EventSource code. JSDoc works with the Typescript validator to provide fantastic insights and code validation if your set up your dev environment to use it. Otherwise, they're just specially formatted comments, so they are non-intrusive and don't require a build step or a compiler. You can run the raw code without any modifications.

What do you think? If this works for you, I'll take a pass at adding JSDoc comments in a separate PR. Like unit tests, the benefits grow exponentially as more code is covered :)

from _hyperscript.

benpate avatar benpate commented on May 26, 2024

Another issue I'm having trouble with is parsing event names correctly. A regular, mixed case string seems to work fine. But if I include a number, or a dash - or a colon : then the parsing breaks. I think I'm probably using the wrong function to identify the event name. What is a better choice instead of parser.requireElement("dotOrColonPath"...)?

from _hyperscript.

1cg avatar 1cg commented on May 26, 2024

parser.requireElement("stringLike") is more flexible, it will allow you to take either a string or a naked string, which is white space terminated.

from _hyperscript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.