Coder Social home page Coder Social logo

Comments (9)

AbhayVAshokan avatar AbhayVAshokan commented on June 28, 2024 2

Let us solve the issues with subdomain as the first part of this issue and take up changes related to adding previews for Excel and Docs in #991.

from neeto-editor.

sandip-mane avatar sandip-mane commented on June 28, 2024 1

Found similar implementation in neetoDesk:

https://github.com/bigbinary/neeto-desk-web/blob/0386303d44fc96f4d885e3b939309ad3eb943884/app/carriers/attachment_carrier.rb#L34-L36

I will create independent issues in neetoDesk and neetoKB.

However, should we standardize it so that this does not happen in future?

from neeto-editor.

sandip-mane avatar sandip-mane commented on June 28, 2024 1

@gaagul we can close this issue. We have another one for adding these features. Ref: #991

from neeto-editor.

gaagul avatar gaagul commented on June 28, 2024

@gaagul _a

from neeto-editor.

gaagul avatar gaagul commented on June 28, 2024

I believe the host app is responsible for the subdomain part, In neetoKb i was able to find : https://github.com/bigbinary/neeto-kb-web/blob/70d1dfe251a1e6fbb36d54035233be96d645fdd4/app/views/api/v1/admin/articles/_attachment.json.jbuilder#L4

@AbhayVAshokan , @sandip-mane , Please let me know you thoughts on this.

from neeto-editor.

gaagul avatar gaagul commented on June 28, 2024

However, should we standardize it so that this does not happen in future?

I couldn't locate any specific initializers for Active Storage. If there's an alternative method it would be great.

from neeto-editor.

sandip-mane avatar sandip-mane commented on June 28, 2024

We can move the AttachmentCarrier to neetoCommons and then use that from all the apps.

Before that, we need to see how other neeto apps are using it.

from neeto-editor.

gaagul avatar gaagul commented on June 28, 2024

Removing the priority label since the issue with urls are fixed and research is needed for adding previews to:

  • Excel
  • Docs
  • PDF
  • Images

from neeto-editor.

gaagul avatar gaagul commented on June 28, 2024

Closing the issue.

from neeto-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.