Comments (9)
Let us solve the issues with subdomain as the first part of this issue and take up changes related to adding previews for Excel and Docs in #991.
from neeto-editor.
Found similar implementation in neetoDesk:
I will create independent issues in neetoDesk and neetoKB.
However, should we standardize it so that this does not happen in future?
from neeto-editor.
@gaagul we can close this issue. We have another one for adding these features. Ref: #991
from neeto-editor.
@gaagul _a
from neeto-editor.
I believe the host app is responsible for the subdomain part, In neetoKb i was able to find : https://github.com/bigbinary/neeto-kb-web/blob/70d1dfe251a1e6fbb36d54035233be96d645fdd4/app/views/api/v1/admin/articles/_attachment.json.jbuilder#L4
@AbhayVAshokan , @sandip-mane , Please let me know you thoughts on this.
from neeto-editor.
However, should we standardize it so that this does not happen in future?
I couldn't locate any specific initializers for Active Storage. If there's an alternative method it would be great.
from neeto-editor.
We can move the AttachmentCarrier to neetoCommons and then use that from all the apps.
Before that, we need to see how other neeto apps are using it.
from neeto-editor.
Removing the priority label since the issue with urls are fixed and research is needed for adding previews to:
- Excel
- Docs
- Images
from neeto-editor.
Closing the issue.
from neeto-editor.
Related Issues (20)
- Drag and drop of videos in MOV format throws 403 error
- Editor UI fixes
- Fix the UI issues in the upload modals in small screens. HOT 1
- Fix the UI issue in the highlight feature which occasionally sets the background color of the text to white instead of the highlighted color.
- Reducing the bundle size HOT 1
- Reduce the bundle size of attachments preview.
- Replace the usages of @uppy for uploads with custom hook. HOT 1
- Move dependencies used in host to peer dependencies list
- Check for alternate ways to preview attachments. HOT 1
- Change the bundling process
- Rewrite the custom upload logic. HOT 1
- Rewrite the logic to search in mentions list.
- Update all Tiptap packages to the latest version. Move all common packages to peer dependencies.
- Performance audit HOT 1
- Add a standardized email/pdf file CSS which ensures all items from neetoEditor are properly formatted HOT 4
- Video dimensions not auto corrected in case of overflow
- After 2000 characters the editor becomes slow
- Verify image upload HOT 1
- Allow hiding the `Delete` option in the `Attachments` component
- Branding changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neeto-editor.